Firefox linux/mac l10n builds fail to build ( http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1345721144.1345721180.14359.gz ) with errors like: /usr/bin/gcc-4.2 -o host_mar_create.o -c -DXP_UNIX -DXP_MACOSX -DNO_X11 -O3 -I../../../modules/libmar/src -I. -I../../../dist/include -I/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/dist/include/nspr -I/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/dist/include/nss -I/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/dist/include/nspr /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_create.c In file included from /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_create.c:12: /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:12:37: error: mozilla/StandardInteger.h: No such file or directory In file included from /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_create.c:12: /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:16: error: 'uint32_t' undeclared here (not in a function) /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:17: error: 'uint64_t' undeclared here (not in a function) /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:43: error: 'uint32_t' undeclared here (not in a function) make[2]: *** [host_mar_create.o] Error 1 make[1]: *** [libs] Error 2 make: *** [default] Error 2 Sounds like fallout due Bug 579517

Does anyone know how I can do this kind of build locally?

So, basically here's what we do: make tier_nspr cd modules/libmar make This is not enough now that libmar depends on MFBT. Instead of `make tier_nspr`, we should do `make tier_base`.

(In reply to Ehsan Akhgari [:ehsan] from comment #2) > This is not enough now that libmar depends on MFBT. Instead of `make > tier_nspr`, we should do `make tier_base`. Subbing in `make tier_base` worked fine in staging. Patch coming up.

Comment on attachment 654786 [details] [diff] [review] Use `make tier_base` instead of `make tier_nspr` https://hg.mozilla.org/build/buildbotcustom/rev/50b2cda3d5b4 This has also made it into production now due to a reconfig.

Hm, looks like linux build fails now with another error in libmar ( http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1345807602.1345807667.27961.gz ): In file included from /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_create.c:12: /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:10:21: error: prtypes.h: No such file or directory In file included from /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_create.c:12: /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:16: error: expected declaration specifiers or ‘...’ before ‘sizeof’ /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:16: warning: data definition has no type or storage class /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:17: error: expected declaration specifiers or ‘...’ before ‘sizeof’ /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:17: warning: data definition has no type or storage class /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:39: error: expected declaration specifiers or ‘...’ before ‘(’ token /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:39: warning: data definition has no type or storage class /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:43: error: expected declaration specifiers or ‘...’ before ‘sizeof’ /builds/slave/m-cen-lnx-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:43: warning: data definition has no type or storage class make[2]: *** [host_mar_create.o] Error 1 No problem on mac build.

And now Aurora is burning too - http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1345811927.1345811968.10559.gz

Ehsan: can you look at the linux bustage please?

Here's the new error: /builds/slave/m-aurora-lnx-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:10:21: error: prtypes.h: No such file or directory I thought that tier_base includes tier_nspr as well, but apparently not. I think we need to make them both. :/

BTW, does this also affect Thunderbird?

Comment on attachment 655011 [details] [diff] [review] make both tier_base and tier_nspr Yes this affects thunderbird, but this patch takes care of that as well

I would appreciate if someone can retest this. I have no idea how to trigger those builds or where the logs go.

(In reply to Ehsan Akhgari [:ehsan] from comment #14) > I would appreciate if someone can retest this. I have no idea how to > trigger those builds or where the logs go. Done: libmar builds again on linux, thanks.

Similar crash on aurora-l10n, see http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2012/08/2012-08-24-04-20-11-mozilla-aurora-l10n/mozilla-aurora-linux64-l10n-nightly-de-bm30-build1-build1588.txt.gz for full example, details: ... In file included from /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_create.c:12: /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:10:21: error: prtypes.h: No such file or directory In file included from /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_create.c:12: /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:15: error: expected declaration specifiers or ‘...’ before ‘sizeof’ /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:15: warning: data definition has no type or storage class /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:15: warning: type defaults to ‘int’ in declaration of ‘PR_STATIC_ASSERT’ /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:16: error: expected declaration specifiers or ‘...’ before ‘sizeof’ /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:16: warning: data definition has no type or storage class /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:16: warning: type defaults to ‘int’ in declaration of ‘PR_STATIC_ASSERT’ /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:38: error: expected declaration specifiers or ‘...’ before ‘(’ token /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:38: warning: data definition has no type or storage class /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:38: warning: type defaults to ‘int’ in declaration of ‘PR_STATIC_ASSERT’ /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:42: error: expected declaration specifiers or ‘...’ before ‘sizeof’ /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:42: warning: data definition has no type or storage class /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_private.h:42: warning: type defaults to ‘int’ in declaration of ‘PR_STATIC_ASSERT’ In file included from /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_create.c:13: /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_cmdline.h:37: error: expected declaration specifiers or ‘...’ before ‘PRUint32’ /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_cmdline.h:39: error: expected declaration specifiers or ‘...’ before ‘PRUint32’ /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_cmdline.h:40: error: expected declaration specifiers or ‘...’ before ‘PRUint32’ /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/src/mar_cmdline.h:59: error: expected declaration specifiers or ‘...’ before ‘PRUint32’ ... My question: was Bug 579517 also applied to aurora? Can the same solution (from central) also be applied to aurora? Is it needed to file a new Bug?

(In reply to Michael Foerster from comment #16) > Similar crash on aurora-l10n, see > http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2012/08/2012-08-24-04- > 20-11-mozilla-aurora-l10n/mozilla-aurora-linux64-l10n-nightly-de-bm30-build1- > build1588.txt.gz for full example, details: > ... > In file included from > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_create.c:12: > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:10:21: error: prtypes.h: No such file or directory > In file included from > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_create.c:12: > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:15: error: expected declaration specifiers or ‘...’ before > ‘sizeof’ > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:15: warning: data definition has no type or storage class > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:15: warning: type defaults to ‘int’ in declaration of > ‘PR_STATIC_ASSERT’ > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:16: error: expected declaration specifiers or ‘...’ before > ‘sizeof’ > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:16: warning: data definition has no type or storage class > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:16: warning: type defaults to ‘int’ in declaration of > ‘PR_STATIC_ASSERT’ > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:38: error: expected declaration specifiers or ‘...’ before > ‘(’ token > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:38: warning: data definition has no type or storage class > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:38: warning: type defaults to ‘int’ in declaration of > ‘PR_STATIC_ASSERT’ > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:42: error: expected declaration specifiers or ‘...’ before > ‘sizeof’ > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:42: warning: data definition has no type or storage class > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_private.h:42: warning: type defaults to ‘int’ in declaration of > ‘PR_STATIC_ASSERT’ > In file included from > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_create.c:13: > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_cmdline.h:37: error: expected declaration specifiers or ‘...’ before > ‘PRUint32’ > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_cmdline.h:39: error: expected declaration specifiers or ‘...’ before > ‘PRUint32’ > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_cmdline.h:40: error: expected declaration specifiers or ‘...’ before > ‘PRUint32’ > /builds/slave/m-aurora-lnx64-l10n-ntly/build/mozilla-aurora/modules/libmar/ > src/mar_cmdline.h:59: error: expected declaration specifiers or ‘...’ before > ‘PRUint32’ > ... > My question: was Bug 579517 also applied to aurora? > Can the same solution (from central) also be applied to aurora? > > Is it needed to file a new Bug? No, the build code should cover it. It's used in both cases. This change made it to production just now, BTW.