Closed Bug 819218 Opened 12 years ago Closed 12 years ago

Permissions Installer - is coded to only allow |desktop-notification| to certified apps, but permissions matrix says all apps should be ALLOW_ACTION

Categories

(Firefox OS Graveyard :: General, defect, P1)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)

Status:
RESOLVED FIXED
Milestone:
B2G C3 (12dec-1jan)
Project Flags:
blocking-basecamp +
Tracking Flags:
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: pauljt, Assigned: gwagner)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

patch
(deleted), patch
sicking
: review+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #819216 +++ The permissions installer states the following: "desktop-notification": { 167 app: DENY_ACTION, 168 privileged: DENY_ACTION, 169 certified: ALLOW_ACTION 170 }, In the permission matrix, it says it should be ALLOW_ACTION for all apps (and PROMPT_ACTION for web content). I'm pretty the PermissionsInstaller.jsm needs to be updated here to reflect the matrix. Not sure what, if anything, needs to be done for the PROMPT_ACTION case for web content. I suspect that we need to special case it in a similar way to geolocation in bug 814294. My guess is that http://mxr.mozilla.org/mozilla-central/source/b2g/components/ContentPermissionPrompt.js#21 needs to have 'desktop-notifcation' added to it. (gwagner, can you comment?)
Gregor, let us know if you don't have time for this.
Assignee: nobody → anygregor
blocking-basecamp: ? → +
Target Milestone: --- → B2G C3 (12dec-1jan)
Attached patch patch (deleted) — — Splinter Review
Attachment #690258 - Flags: review?(jonas)
https://hg.mozilla.org/mozilla-central/rev/99fed1469403
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
status-b2g18: --- → fixed
Whiteboard: [qa-][status-b2g18:fixed] → [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: