Boris Zbarsky [:bzbarsky] Reporter
	Description • 12 years ago

      No description provided.

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 1 • 12 years ago

only store the things we care about in ResolveName so we don't have to
do all the complicated filtering by tag name and whatnot: just do a
hashtable lookup and move on...

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 4 • 12 years ago

There's another testcase at https://bug-104623-attachments.webkit.org/attachment.cgi?id=178683 that can be used to test correctness and can get timing added to measure perf...

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 6 • 12 years ago

Note that we'll need to make the proxy handler for this stuff deal with the [Unforgeable] location.  Right now this patch fails codegen even with bug 821438 fixed.  :(

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 7 • 12 years ago

We'll also need the proxy handler to expose names when called via an Xray but pretend to not be [OverrideBuiltins] in that case...  Might not be too bad because Xrays skip the expando get anyway, so it'll just be a matter of checking up the proto chain like we do for most handlers, but only in the Xray case.

	Peter Van der Beken [:peterv] Assignee
	Comment 8 • 12 years ago

I already have that part working.

	Peter Van der Beken [:peterv] Assignee
	Comment 9 • 11 years ago

We also need to reimplement .all.

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 10 • 11 years ago

Hmm.  Just because the way it's hooked up right now is messed up?  That seems like a side-project that we need to do anyway; we need a separate bug, yes?

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 12 • 11 years ago

Peter, what's our plan for nsIPluginDocument and nsIImageDocument?  I guess we could just introduce extra interfaces to hold the relevant methods...

	Peter Van der Beken [:peterv] Assignee
	Comment 14 • 11 years ago

Updated to trunk. r=me.

	Peter Van der Beken [:peterv] Assignee
	Comment 16 • 11 years ago

This mostly just moves and reindents code.

	Peter Van der Beken [:peterv] Assignee
	Comment 17 • 11 years ago

Doing this in the NamedGetter for now. We can design a better solution in the future.

	Peter Van der Beken [:peterv] Assignee
	Comment 18 • 11 years ago

Comment on attachment 691184 [details] [diff] [review]
part 2.  Turn on WebIDL bindings for HTMLDocument.

Moving this to a separate bug.

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 19 • 11 years ago

Comment on attachment 729531 [details] [diff] [review]
Implement GetSupportedNames on HTMLDocument

Review of attachment 729531 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsGenericHTMLElement.h
@@ +717,5 @@
>  
>    static bool TouchEventsEnabled(JSContext* /* unused */, JSObject* /* unused */);
>  
> +  static inline bool
> +  ExposeIdAsHTMLDocumentProperty(Element* aElement)

This sounds as if it would actively go and expose something. Maybe ShouldExpose...?

::: content/html/document/src/nsHTMLDocument.cpp
@@ +2395,4 @@
>  void
>  nsHTMLDocument::GetSupportedNames(nsTArray<nsString>& aNames)
>  {
>    // Nothing, for now.  We should fix that.

We fixed it!

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 20 • 11 years ago

Comment on attachment 729531 [details] [diff] [review]
Implement GetSupportedNames on HTMLDocument

r=me

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 21 • 11 years ago

Comment on attachment 729533 [details] [diff] [review]
Refactor code to support document.all

r=me, I guess

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 22 • 11 years ago

Comment on attachment 729535 [details] [diff] [review]
Hook up document.all in the HTMLDocument NamedGetter

This is icky, but ok for now.

Something here needs to enter the compartment of the wrapper on cx, right?  Either the NamedGetter or nsHTMLDocumentSH::TryResolveAll.

r=me with that.

	Peter Van der Beken [:peterv] Assignee
	Comment 23 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/8960293f0fb3
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e02690e9bd
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d97c190fe24
https://hg.mozilla.org/integration/mozilla-inbound/rev/85bcef2ac1fd

I removed the getter from the WebIDL file for now, we need unforgeable support for proxies first.

	Ryan VanderMeulen [:RyanVM]
	Comment 24 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/8960293f0fb3
https://hg.mozilla.org/mozilla-central/rev/a2e02690e9bd
https://hg.mozilla.org/mozilla-central/rev/1d97c190fe24
https://hg.mozilla.org/mozilla-central/rev/85bcef2ac1fd