Closed
Bug 855971
Opened 12 years ago
Closed 12 years ago
Switch HTMLDocument to WebIDL bindings
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: bzbarsky, Assigned: peterv)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed, site-compat)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The bug we used to have on this got repurposed.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → peterv
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #731080 -
Attachment is obsolete: true
Attachment #743209 -
Flags: review?(bzbarsky)
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 743209 [details] [diff] [review]
v2
>+ is(globalScope.querySelectorAll(".variables-view-variable:not([non-match])").length, 1,
> "There should be 2 variables displayed in the global scope");
Fix the test message?
>+ is(innerScope.querySelectorAll(".variables-view-property:not([non-match])").length, 7,
> "There should be 8 properties displayed in the inner scope");
And here. Do we understand why these were needed?
r=me with that.
Attachment #743209 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Backed out because of browser-chrome test failures: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=a2245b038bcc
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b63238518a3
Reporter | ||
Comment 6•12 years ago
|
||
Looks like the debugger tests no longer need some of the changes from this bug (the [object Proxy] bit because jimb fixed that bustage, and not sure about the rest).
I took out those parts of the patch, verified that the tests that failed when this was pushed now pass for me locally, and pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/adaaf6641785
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Updated•11 years ago
|
Keywords: dev-doc-needed,
site-compat
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•