Frank Yan (:fryn) Assignee
	Description • 11 years ago

Combine page contextual items (URL bar, bookmark star, etc.) into a single app bar at the bottom of the screen.

	Marco Mucci [:MarcoM]
	Comment 1 • 11 years ago

Hey Asa, this requires a new story.

	Frank Yan (:fryn) Assignee
	Comment 2 • 11 years ago

WIP from a while ago before I had design guidance from Stephen.
Complete patch coming soon.

	Marco Mucci [:MarcoM]
	Comment 3 • 11 years ago

Story is on hold.

	Asa Dotzler [:asa]
	Comment 4 • 11 years ago

This story probably shouldn't be on hold. This is the last major UI re-shuffling and we should try to get it completed in the next iteration if at all possible.

	Marco Mucci [:MarcoM]
	Comment 5 • 11 years ago

Hi Asa, it was only on hold because it required a user story.  Once it is supplied this bug can be moved to the story backlog for selection.

	Frank Yan (:fryn) Assignee
	Comment 6 • 11 years ago

Now that bug 800996 has landed (on mozilla-inbound and next mozilla-central shortly), I'm taking this as I am sitting in the same room as Stephen and Yuan (of UX) everyday this week, who will be able to provide all the UX guidance I need to finish this story. If I don't have a patch up by the end of this iteration, I'll relinquish this bug to avoid blocking other folks.

	Asa Dotzler [:asa]
	Comment 7 • 11 years ago

Story: 

As a Metro Firefox user, I have quick and convenient access to the Firefox app bar so that I can identify the current page, edit and load addresses, navigate back and forward, reload the page, bookmark pages, find in page, view in desktop, and pin  to Windows Start. 

Flow: 

1. The Metro user opens the website http://www.cnn.com
2. The Metro Firefox user swipes in from the top or bottom of the screen and sees a beautiful Firefox app bar appear at the bottom of the page.
3. The user looks over the app bar and sees a back button, address field, reload button, star and pin to start buttons.

	Frank Yan (:fryn) Assignee
	Comment 8 • 11 years ago

If the patch in bug 869777 hasn't landed yet, apply the patch in bug 869777 first.

	Matt Brubeck (:mbrubeck)
	Comment 9 • 11 years ago

Comment on attachment 749038 [details] [diff] [review]
patch

Review of attachment 749038 [details] [diff] [review]:
-----------------------------------------------------------------

Everything in this patch looks good to me, but there's a problem somewhere (I don't know where) with snapped view.  We don't need to get snapped view working *perfectly* to land this, but could you look into this and see if there's an easy way to restore basic functionality before landing?

	Frank Yan (:fryn) Assignee
	Comment 10 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b994338768d

(In reply to Matt Brubeck (:mbrubeck) from comment #9)
> Everything in this patch looks good to me, but there's a problem somewhere
> (I don't know where) with snapped view.  We don't need to get snapped view
> working *perfectly* to land this, but could you look into this and see if
> there's an easy way to restore basic functionality before landing?

Yeah, I added the following rule to address this for now:

#toolbar[viewstate="snapped"] > #tool-stop ~ toolbarbutton {
  visibility: collapse;
}

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/8b994338768d

	Marco Mucci [:MarcoM]
	Comment 12 • 11 years ago

For testing and verification.

	Marco Mucci [:MarcoM]
	Comment 13 • 11 years ago

Canceling test request until final dependency is resolved.

	Marco Mucci [:MarcoM]
	Comment 14 • 11 years ago

For testing and verification.

	Virgil Dicu [:virgil] [QA]
	Comment 15 • 11 years ago

Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20130526 Firefox/24.0

- verified that app bar is invoked with Ctrl + Z and right click
- items specified in comment 7 are displayed in the app bar - apart from the reload button (bug 876406): Back/Forward buttons, address bar, Downloads, Zoom In, Zoom Out, Bookmark, Pin, Tool button (with View in Desktop and Find options)
-items are functional - apart from Zoom in/Out (bug 876408)

Also logged bug 876401 and bug 876417 in addition to the ones mentioned above. 

I've logged separate bugs for every issue, so this can be set to verified.

	Kamil Jozwiak [:kjozwiak]
	Comment 16 • 11 years ago

Went through the following "Story" for iteration #9 testing and found several issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-25-03-12-38-mozilla-central/

- Used the "Combined App Bar" and most of the bugs are still issues (Bug 878531, Bug 878618, Bug 878619)
- Found two new defects that are related to the "Combined App Bar" (Bug 887120, Bug 887138)

	Samvedana (:Samvedana)
	Comment 17 • 11 years ago

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130812030209
Built from http://hg.mozilla.org/mozilla-central/rev/87c1796bc46c

WFM
Tested on windows 8 using latest nightly for iteration-11. I saw a back button, address field, reload button, star and pin buttons in app bar.