Corey Frang [:gnarf] Reporter
	Description • 11 years ago

Per https://bugzilla.mozilla.org/show_bug.cgi?id=868225#c2:

- For video capture, an MMS Video Limit mode is supported The camera application must support video capture that stops automatically before the file reaches a maximum size to match the handset's maximum MMS attachment file size, being configurable as part of the variant process according to the network provider's network limits.

The SMS side will add a "maxFileSize" property to the "pick" MozActivity, we need to make sure that the video capture in camera uses this.

	gasolin@mozilla.com
	Comment 1 • 11 years ago

share some investigation,

currently camera app did not support pick video,
and not support open in record mode yet
(camera always open as camera mode, tap video icon to switch to record mode).

bug 853349 'open in record mode when trigger camera with 'record' activity by video type' is similar to that 'pick' video action.

	Dale Harvey (:daleharvey) Assignee
	Comment 2 • 11 years ago

I used the label 'maxFileSizeBytes' to be consistent with previous usage, I also think its clearer

	David Flanagan [:djf]
	Comment 3 • 11 years ago

Comment on attachment 759577 [details]
Pointer to GH

r=djf for github commit 3ce908c55452cfb26d8e25408a0aae8e962e5344

	Corey Frang [:gnarf] Reporter
	Comment 4 • 11 years ago

Hrm, we already committed maxFileSize as a key in SMS - I suppose we can sneak the word "Bytes" in there...  I think that is a tad redundant though don't you?  What else would you measure FileSize in?

	Mike Habicher [:mikeh] (high bugzilla latency)
	Comment 5 • 11 years ago

(In reply to Corey Frang (@ conference until Jun 14) [:gnarf] [:gnarf37] from comment #4)
>
> Hrm, we already committed maxFileSize as a key in SMS - I suppose we can
> sneak the word "Bytes" in there...  I think that is a tad redundant though
> don't you?  What else would you measure FileSize in?

Kilobytes? Megabytes?

My intention was for it to parallel maxVideoLengthMs member, which is much more ambiguous without the units on it.

	Alex Keybl [:akeybl]
	Comment 6 • 11 years ago

Does this need checkin-needed added? What are we waiting on if this is r+?

	Dale Harvey (:daleharvey) Assignee
	Comment 7 • 11 years ago

It is waiting on https://bugzilla.mozilla.org/show_bug.cgi?id=853349 to be landed, its a fairly minor ammendment that can be committed as soon as that patch lands (I will probably do the patch for sms at the same time once it has landed)

	Dale Harvey (:daleharvey) Assignee
	Comment 8 • 11 years ago

The previous patch was r+'d, but this has some further changes so requesting new review.

	David Flanagan [:djf]
	Comment 9 • 11 years ago

r=djf for github commit 882778c

You didn't attached that github PR to this bug, so I can't actually set an r+ flag here.

The code looks good. I was unable to actually exercise it, however. It looks like maybe the contacts app is not actually setting a size limit?  I'm using gaia master with b2g18, so my build may be incorrect.

If you've tested it and it works, then go ahead and land.

	David Flanagan [:djf]
	Comment 10 • 11 years ago

Comment on attachment 767026 [details]
Pointer to GH

Mid-air collision with the new PR attachment. Now I can set a real r+

	Dale Harvey (:daleharvey) Assignee
	Comment 11 • 11 years ago

Merged in: https://github.com/mozilla-b2g/gaia/commit/caedc9f9de79605da705697790f92287c9c361fe

Uplifted to v1-train: https://github.com/mozilla-b2g/gaia/commit/05ff7b42362ac81216921b97f1f606568156dfb1

	John Ford [:jhford] CET/CEST Berlin Time
	Comment 12 • 11 years ago

Marking branch status per comment 11

	John Ford [:jhford] CET/CEST Berlin Time
	Comment 13 • 11 years ago

1.1hd: 05ff7b42362ac81216921b97f1f606568156dfb1