Like in NS, I think the status bar should display the download speed and the remaining time or "xxxk read" instead of "Transfering Data from.." after reasonable delay when the file takes time. For exemple Quicktime Movie, long text file(http://europa.eu.int/en/comm/eurostat/research/isi/glossaryfe.htm), "huge" image...

Seems reasonable, confirming as NEW.

*** Bug 90773 has been marked as a duplicate of this bug. ***

*** Bug 92832 has been marked as a duplicate of this bug. ***

*** Bug 92989 has been marked as a duplicate of this bug. ***

*** Bug 75247 has been marked as a duplicate of this bug. ***

Yes please. One day I'll get around to doing a full spec for status bar text, but for now here's a mini-spec for the loading part. If you know the size of all objects in the page: 14 K of 62 K read (7.4 K/second), 3 seconds remaining ... If you know the size of the main document and all HTML/XML frames, but you don't know the size of pictures, plain text objects, etc. embedded in them: 14 K of 34 K read (7.4 K/second) ... [the total figure increases as you find out more, but that's ok] If you don't know the size of the main document and all HTML/XML frames: 14 K read (7.4 K/second) ... This bug may end up being fixed in several small steps, so please keep non-patch spam in the bug report to a minimum. --> Networking.

*** Bug 120428 has been marked as a duplicate of this bug. ***

-> file manager

-> file handling

*** Bug 139130 has been marked as a duplicate of this bug. ***

*** Bug 140246 has been marked as a duplicate of this bug. ***

*** Bug 140594 has been marked as a duplicate of this bug. ***

*** Bug 143111 has been marked as a duplicate of this bug. ***

*** Bug 156417 has been marked as a duplicate of this bug. ***

*** Bug 157901 has been marked as a duplicate of this bug. ***

*** Bug 159523 has been marked as a duplicate of this bug. ***

*** Bug 166586 has been marked as a duplicate of this bug. ***

Please note that the time display has been removed intentionally by bug 48436.

Helge, that has nothing to do with this bug, as this bug covers the information _while the page loads_

*** Bug 175231 has been marked as a duplicate of this bug. ***

yes, pleeeeeeeze! I don't know why it's been taken out in the first place (since it was in the original Netscape codebase). I think it's useful information: If a page takes long time to load, is it because my connection is slow or because the author wrote a **** 200k+ page? If I see that my connection speed is slow I know who and how to address the problem. If it's the page's fault I know not to visit it anymore. So it really is useful info. I even like how Opera shows the loaded/total no. of images but I don't know wether there'll be a majority for it. I don't think that Mozilla/Phoenix are about hiding what's going on under the hood. - Stephan PS: could this maybe be realized as an extension? So people who want it, install it and the others don't.

>I don't know why it's been taken out in the first place (since >it was in the original Netscape codebase). there was a rewrite of the whole code, so it was not "taken out". please don't add useless comments like the one you added.

*** Bug 205827 has been marked as a duplicate of this bug. ***

Yes this enhancement should definitely be impletemented ASAP. It is very useful and nearly all really good browsers have it. It is very important to know the size, time it took to load the page and connection speed. Switching from Opera to Firebird this feature is one i deeply miss.

Yes this enhancement should definitely be impletemented ASAP. It is very useful and nearly all really good browsers have it. It is very important to know the size, time it took to load the page and connection speed. Switching from Opera to Firebird this feature is one i deeply miss.

Comment on attachment 128851 [details] [diff] [review] Patch + this.status2 = " ["+parseInt(aCurTotalProgress/1024)+" of " + +parseInt(aMaxTotalProgress/1024)+" kB ("+parseInt(percentage)+"%) at " + +parseInt(100*aCurTotalProgress/(1024*elapsed))/100+" kB/s, " + +parseInt(elapsed*(aMaxTotalProgress-aCurTotalProgress)/aCurTotalProgress+1)+" s remaining]"; this needs to be localizable Also, you can avoid the parseInt if you use the bitwise shift operator instead of /1024, i.e.: aCurTotalProgress>>10 + if (aMessage.indexOf("Transferring") == 0) { This will not work in non-english locales thanks for making a patch!

localizable? how do i make into that? sorry for being such a newbie :)

I just saw I replaced one "start" too much...

i applied the patch to those two files.. still didnt see any difference in the status bar? any ideas?

@Vegeta: It will only work if the progress bar is also working. This is only the case on some pages (but that is another Bug). Try <http://msdn.microsoft.com/vstudio/downloads/updates/sp/vs6/sp5/>.

my progress bar is working..

Comment on attachment 128860 [details] [diff] [review] Patch v2.1 well, I just tried applying the patch... didn't work well: patching file nsBrowserStatusHandler.js Hunk #5 FAILED at 369. Hunk #6 FAILED at 76. patch unexpectedly ends in middle of line 2 out of 6 hunks FAILED -- saving rejects to file nsBrowserStatusHandler.js.rej patch unexpectedly ends in middle of line Also, I can't superreview patches, and jag must either review or super-review xpfe patches. as I don't really know this code here well, I'd prefer it if jag reviewed it + this.statusProgress = " ["+(aCurTotalProgress>>10)+" of " + +(aMaxTotalProgress>>10)+" kB ("+parseInt(percentage)+"%) at " + +parseInt(100*(aCurTotalProgress>>10)/elapsed)/100+" kB/s, " + +parseInt(elapsed*(aMaxTotalProgress-aCurTotalProgress)/aCurTotalProgress+1)+" s "+remaining+"]"; this is still not localizable + if (aMessage.indexOf(transferring) == 0) { + if (aMessage.indexOf(transferring) == 0) { well, I can't say I like this... is there no better way? Can you do this in onStateChange instead, and check aStateFlags?

Do the statistics remain in the statusbar after the page is done loading? They should, otherwise they will be unnoticed in most cases...

onStateChange has one Problem: aWebProgress and aRequest are always null, and aStateFlags is either STATE_START || STATE_IS_REQUEST || STATE_IS_DOCUMENT || STATE_IS_NETWORK or STATE_STOP || STATE_IS_NETWORK || STATE_IS_WINDOW. I also tried aWebProgress, aRequest and aStatus in onStatusChange. They are always null.

Comment on attachment 128962 [details] [diff] [review] Patch v3 Also see bug 175231. Just use |(new Date).getTime()| or |Date.now()| instead of using a helper variable. Don't use parseInt to get an integer from a float, it's slow. Use Math.floor and Math.ceil instead. Don't hardcode spaces for UI in your JS. Add another string to the .properties file composed of the complete text you want with proper substitution placeholders. How come you're setting statusProgress on both this.status (causing statusTextField.label to be updated) and statusMeter.label? Is this going to show up twice in our UI?

Assigning to me purely to keep track of this.

Comment on attachment 129646 [details] [diff] [review] Patch v4 I didn't see that "www.web.de"...

Latest patch, though applies to trunk cleanly, doesn't add any statistics to status bar. I see usual "Transferring data from". Final document load time is there though: "Done [0.138s]".

Comment on attachment 129824 [details] [diff] [review] Patch v4.1 doesn't apply anymore

darin: Since your checkin for Bug 192022 this patch doesn't work any more, but I cannot figure out any good way to forward the old size values to nsBrowserStatusHandler.js. Any ideas?

(In reply to comment #45) > darin: Since your checkin for Bug 192022 this patch doesn't work any more, but I > cannot figure out any good way to forward the old size values to > nsBrowserStatusHandler.js. Any ideas? sorry, no... i don't have any suggestions. perhaps you could explain in detail how your patch is meant to work. then, i might be able to spot the problem.

This would display "n items remaining" in the status bar if it wasn't immediately overwritten with "Transferring data from...". Maybe it'll be useful if someone else can figure out the rest.