Bug 811409 has been tracking work to get C++ unit tests running from the test package. There is a patch there, but it can't be landed without updates to the mozharness config files to support the C++ unit tests. I've attached a sample config that I used for local testing on Linux to Bug 811409. Getting C++ unit tests running on Cedar would solve the config file problem and make it possible to test these changes across all the desktop platforms.

Aki, is this something you can help us drive with the set of interns you have working on mozharness stuff? If you're not the right person, please let us know who is. Many thanks!

(In reply to Clint Talbert ( :ctalbert ) from comment #1) > Aki, is this something you can help us drive with the set of interns you > have working on mozharness stuff? If you're not the right person, please > let us know who is. Many thanks! I don't actually specify who works on what, when; that tends to be :coop, :catlee, and :joduinn. I just help people who are working in areas I know. I think when we landed bug 811409, it went live across the board, which is why we backed it out. Afaict it's not a question of enabling this on Cedar; it's a matter of not enabling it on every other branch, which happens whenever this merges to production. I think one approach would be for :dminor, or someone else, to take the sample config diff changes (probably everything referencing cppunittest) and to apply those changes to the config files in http://hg.mozilla.org/build/mozharness/file/b468fb3a8f8c/configs/unittests . Then that patch can be landed along with https://bugzilla.mozilla.org/attachment.cgi?id=775766 on http://hg.mozilla.org/users/asasaki_mozilla.com/ash-mozharness , and then any ash unittests should be running cppunittests. If those go green, the corresponding patch should be ready for review.

I'll give that a shot tomorrow and see how it goes.

:dminor pinged me in IRC earlier -- I think the ash run looks good; the patch should be reviewable+landable. I'll be on PTO next week, but we should be able to schedule these unit tests by: * adding a CPPUNIT like these: http://hg.mozilla.org/build/buildbot-configs/file/6e6088fc8791/mozilla-tests/config.py#l396 * enabling on just Cedar, potentially like we're doing for metro right now: http://hg.mozilla.org/build/buildbot-configs/file/6e6088fc8791/mozilla-tests/config.py#l1455 except I imagine we'd want them on more platforms than win8, correct? (which platforms?)

The patch for Bug 811409 is in production. Is anything else needed from me to be able to turn this on for Cedar?

(In reply to Dan Minor [:dminor] from comment #5) > The patch for Bug 811409 is in production. Is anything else needed from me > to be able to turn this on for Cedar? Just the answer to this part of aki's question. After this is answered the remaining work is on releng to accomplish (In reply to Aki Sasaki [:aki] from comment #4) > * enabling on just Cedar, potentially like we're doing for metro right now: > http://hg.mozilla.org/build/buildbot-configs/file/6e6088fc8791/mozilla-tests/ > config.py#l1455 > > except I imagine we'd want them on more platforms than win8, correct? > (which platforms?)

We would want to run these for any platform that currently does the unit tests as part of make check. As far as I know, that would be everything that is not Android or B2G.

:dminor, do the commandline options look right?

Comment on attachment 790494 [details] [diff] [review] cppunit on cedar Review of attachment 790494 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.

Comment on attachment 790494 [details] [diff] [review] cppunit on cedar https://hg.mozilla.org/build/buildbot-configs/rev/40536c92e895

In production.

These are running on Cedar as 'U' since TBPL doesn't know about these.

desktop_unittest.py: error: no such option: --cppunittest-suite Looks like we need to add this commandline option here? http://hg.mozilla.org/build/mozharness/file/825c92dca271/scripts/desktop_unittest.py#l34

Yes, I missed that when I was working on this and was using something in my config file to force the test suite to run.

argv: ['/tools/buildbot/bin/python', 'scripts/scripts/desktop_unittest.py', '--cppunittest-suite', 'cppunittest', '--download-symbols', 'true'] Required config file not set! (use --config-file option) program finished with exit code 255

Comment on attachment 792983 [details] [diff] [review] Add the missing config files for cppunittests https://hg.mozilla.org/build/buildbot-configs/rev/15f9ba1f2ea0

Live in production.

Orange, not red :)