Closed Bug 912192 Opened 11 years ago Closed 11 years ago

cppunit tests scheduling changes

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: kmoir)

References

Details

(Whiteboard: [capacity])

Attachments

(1 file)

bug912192.patch
(deleted), patch
rail
: review+
kmoir
: checked-in+
Details | Diff | Splinter Review
We should stop scheduling the fedora jobs :-) https://tbpl.mozilla.org/?tree=Cedar&showall=1&jobname=cpp
Ed, should we be doing these for release builds?
(In reply to Dan Minor [:dminor] from comment #1) > Ed, should we be doing these for release builds? Define release? There are no cppunit tests being scheduled on https://tbpl.mozilla.org/?tree=Mozilla-Release&showall=1&jobname=cpp Normally when introducing a new test suite, we let it propagate through the various release branches {aurora, beta, release} on the usual 6 week cadence.
Sorry, by release I meant 'opt' builds. If things continue to look green, I think we should expand these beyond Cedar soon. These tests run now as part of make check, so I don't expect them to give too much trouble.
(In reply to Dan Minor [:dminor] from comment #3) > Sorry, by release I meant 'opt' builds. > > If things continue to look green, I think we should expand these beyond > Cedar soon. These tests run now as part of make check, so I don't expect > them to give too much trouble. Ah I see (the 'opt' builds aren't actually what we release, 'pgo' is closer, 'nightly' closer still, but not 100%... but that's another mini rant! :-)). I'm not sure -- ted, should the cppunit tests be run on opt builds too?
Flags: needinfo?(ted)
We should be running them on all of opt, debug and pgo. They currently get run during the "make check" portion of builds, but we should turn that off when we're satisfied with the standalone job (before we turn them on on m-c and related branches, presumably).
Flags: needinfo?(ted)
(But comment 0 is correct in that we don't need to be running them on Fedora, just Ubuntu.)
Thanks Ted! :-) New summary of desired changes: * Stop scheduling cppunit tests on fedora (we just want ubuntu). * Also schedule them on opt/pgo, since they're currently only switched on for debug.
Summary: cppunit tests are being scheduled on both fedora and ubuntu on cedar → cppunit tests scheduling changes
I can look at this after testing my changes in bug 912997 for adding jit tests.
Assignee: nobody → kmoir
Attached patch bug912192.patch (deleted) — — Splinter Review
Attachment #805361 - Flags: review?(rail)
Attachment #805361 - Flags: review?(rail) → review+
Attachment #805361 - Flags: checked-in+
In production
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reopening because changes in bug 892569 had to be reverted.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
oops reopened wrong bug should have been bug 920989
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: