Closed
Bug 918414
Opened 11 years ago
Closed 11 years ago
Add support for win64+gpo platform
Categories
(Infrastructure & Operations Graveyard :: CIDuty, task)
Tracking
(firefox26 fixed, firefox27 fixed, firefox-esr24 fixed, b2g-v1.2 fixed)
People
(Reporter: jhopkins, Assigned: jhopkins)
References
Details
Attachments
(5 files, 4 obsolete files)
(deleted),
patch
|
rail
:
review+
jhopkins
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
jhopkins
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bhearsum
:
review+
jhopkins
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
catlee
:
review+
jhopkins
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bhearsum
:
review+
jhopkins
:
checked-in+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
add win64-gpo platform. defaulted to disabling the changes on all branches so we can land this patch ahead of actually enabling the platform to avoid bitrot.
Attachment #807316 -
Flags: review?(bhearsum)
Comment 2•11 years ago
|
||
Comment on attachment 807316 [details] [diff] [review]
[buildbot-configs] add win64-gpo platform, defaulting to disabled on all branches
Review of attachment 807316 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine overall, just a couple of minor things noted below.
::: mozilla/b2g_config.py
@@ +1124,5 @@
>
> +# MERGE DAY
> +# Migrate branches to win64-gpo platform
> +for branch in BRANCHES:
> + if True: #branch in ('mozilla-aurora','mozilla-b2g18_v1_0_1','mozilla-b2g18_v1_1_0_hd'):
This "if True" obviously needs to go. You should also update and make use of the new "items_before" helper so that you don't need to list specific branches here. Same goes for the similar blocks in other configs.
::: mozilla/production_config.py
@@ +14,5 @@
> 'linux': LINUX_VMS + LINUX_IXS,
> 'linux64': LINUX64_IXS,
> 'win32': WIN32_IXS,
> 'win64': WIN64_IXS,
> + 'win64-gpo': WIN64_GPO,
Is there a different name we can use for these? GPO is a technology, and I don't think it makes much sense to put in the slave class. Even something like win64-rev2 would be better IMO.
Attachment #807316 -
Flags: review?(bhearsum) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Renamed platform to win64-rev2, removed the commented-out branch names.
Depending on how we want to roll out this platform (eg. on a project branch first), we may want to initially list branch names, then move to the "items-before" branch selection that you suggested.
Attachment #807316 -
Attachment is obsolete: true
Attachment #807404 -
Flags: review?(bhearsum)
Comment 4•11 years ago
|
||
Comment on attachment 807404 [details] [diff] [review]
[buildbot-configs] add win64-gpo platform, defaulting to disabled on all branches
Review of attachment 807404 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to John Hopkins (:jhopkins) from comment #3)
> Created attachment 807404 [details] [diff] [review]
> [buildbot-configs] add win64-gpo platform, defaulting to disabled on all
> branches
>
> Renamed platform to win64-rev2, removed the commented-out branch names.
>
> Depending on how we want to roll out this platform (eg. on a project branch
> first), we may want to initially list branch names, then move to the
> "items-before" branch selection that you suggested.
I'm not fussy on what we do mid-rollout as long as we keep it as clean as possible in the end.
Attachment #807404 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 5•11 years ago
|
||
This will need to be landed and synced before the buildbot-configs patch lands.
Attachment #807411 -
Flags: review?(rail)
Updated•11 years ago
|
Attachment #807411 -
Flags: review?(rail) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 807411 [details] [diff] [review]
[puppet] add win64-rev2 platform to build and try BuildSlaves.py
https://hg.mozilla.org/build/puppet/rev/20d8ed18a81a
Attachment #807411 -
Flags: checked-in+
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 807404 [details] [diff] [review]
[buildbot-configs] add win64-gpo platform, defaulting to disabled on all branches
https://hg.mozilla.org/build/buildbot-configs/rev/500790cdb1f0
Attachment #807404 -
Flags: checked-in+
Assignee | ||
Comment 8•11 years ago
|
||
Add win64-rev2 to BuildSlaves.py.template to satisfy buildbot-configs tests.
Attachment #807743 -
Flags: review?(rail)
Updated•11 years ago
|
Attachment #807743 -
Flags: review?(rail) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #807745 -
Flags: review?(rail)
Updated•11 years ago
|
Attachment #807745 -
Flags: review?(rail) → review+
Assignee | ||
Comment 10•11 years ago
|
||
Comment on attachment 807743 [details] [diff] [review]
[buildbot-configs] add win64-rev2 to BuildSlaves.py.template
https://hg.mozilla.org/build/buildbot-configs/rev/1d6be8a22dfe
Attachment #807743 -
Flags: checked-in+
Assignee | ||
Comment 11•11 years ago
|
||
Comment on attachment 807745 [details] [diff] [review]
[buildbot-configs] don't allow win64-rev2 try and production hostnames to overlap
https://hg.mozilla.org/build/buildbot-configs/rev/a57e56c3de6b
Attachment #807745 -
Flags: checked-in+
Assignee | ||
Updated•11 years ago
|
Attachment #807745 -
Flags: checked-in+ → checked-in-
Assignee | ||
Comment 12•11 years ago
|
||
Comment on attachment 807404 [details] [diff] [review]
[buildbot-configs] add win64-gpo platform, defaulting to disabled on all branches
Backed out in https://hg.mozilla.org/build/buildbot-configs/rev/fa7c262cbd86
Attachment #807404 -
Flags: checked-in+ → checked-in-
Comment 13•11 years ago
|
||
In case we have the conversation of naming new machines in the future, here's a reference to the document we agreed on:
https://wiki.mozilla.org/ReleaseEngineering/Slave_Naming
(Since I saw this naming being used "ix-mn-w0864-XXX" which I assume it is only for experimental purposes)
Assignee | ||
Comment 14•11 years ago
|
||
This patch needs to be present on any branch that uses the win64-rev2 build slaves.
Attachment #809348 -
Flags: review?(catlee)
Assignee | ||
Comment 15•11 years ago
|
||
Attachment #807404 -
Attachment is obsolete: true
Attachment #807745 -
Attachment is obsolete: true
Attachment #809362 -
Flags: review?(bhearsum)
Updated•11 years ago
|
Attachment #809348 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 16•11 years ago
|
||
improved patch that we can land in advance of switching a branch to win64-rev2 build slaves
Attachment #809348 -
Attachment is obsolete: true
Attachment #809392 -
Flags: review?(catlee)
Updated•11 years ago
|
Attachment #809362 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 17•11 years ago
|
||
Comment on attachment 809362 [details] [diff] [review]
[buildbot-configs] win64-rev2 configuration, disabled on all branches
https://hg.mozilla.org/build/buildbot-configs/rev/96f6f2a7d3a3
Attachment #809362 -
Flags: checked-in+
Comment 18•11 years ago
|
||
In production
Updated•11 years ago
|
Attachment #809392 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 19•11 years ago
|
||
Comment on attachment 809392 [details] [diff] [review]
[mozilla-central] look for gapi.data on c: then e:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80f98d794003
Attachment #809392 -
Flags: checked-in+
Assignee | ||
Comment 20•11 years ago
|
||
Attachment #809935 -
Flags: review?(bhearsum)
Updated•11 years ago
|
Attachment #809935 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 21•11 years ago
|
||
Comment on attachment 809935 [details] [diff] [review]
[buildbot-configs] enable win64-rev2 on cedar
http://hg.mozilla.org/build/buildbot-configs/rev/c208fb23c9ce
and in production.
Attachment #809935 -
Flags: checked-in+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 23•11 years ago
|
||
What are the next branches that we're going to target?
Assignee | ||
Comment 24•11 years ago
|
||
'try' first, then central+inbound. See https://groups.google.com/forum/#!topic/mozilla.dev.platform/VSgwbVIuDwg for cutover options discussion.
Comment 25•11 years ago
|
||
Comment 26•11 years ago
|
||
Updated•11 years ago
|
status-b2g-v1.2:
--- → fixed
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
Updated•5 years ago
|
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•