Closed
Bug 10872
Opened 26 years ago
Closed 22 years ago
[FEATURE] Remember last selected message in a folder
Categories
(SeaMonkey :: MailNews: Message Display, defect, P3)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.3beta
People
(Reporter: scottputterman, Assigned: sspitzer)
References
Details
Attachments
(1 file, 4 obsolete files)
(deleted),
patch
|
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
bug tracking feature in Summary.
Reporter | ||
Updated•26 years ago
|
Target Milestone: M11 → M14
Reporter | ||
Comment 1•26 years ago
|
||
setting M14
Reporter | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Updated•25 years ago
|
Target Milestone: M14 → M15
Comment 2•25 years ago
|
||
Sol: remember sort/thread mode is more important for B1 than remember last
selected message.
Reporter | ||
Updated•25 years ago
|
Target Milestone: M15 → M18
Reporter | ||
Comment 3•25 years ago
|
||
Disagree this is beta. How do I disagree? Do I just change the target and see
if anyone disagrees back? OK, I will try it. Setting M18. I do agree with
remember sort and thread however.
Guess we need to log a bug to remove the pref from the prefs ui main mail and
newsgroups panel, huh? I'll do that...
QA Contact: lchiang → laurel
bug #46342 logged to remove pref.
Not much left on the panel, eh?
Reporter | ||
Comment 10•24 years ago
|
||
moving to mozilla0.8 milestone.
Target Milestone: Future → mozilla0.8
Reporter | ||
Comment 11•24 years ago
|
||
reassigning to chuang
Assignee: putterman → chuang
Status: ASSIGNED → NEW
Reporter | ||
Comment 13•24 years ago
|
||
marking nsbeta1-
Reporter | ||
Comment 14•24 years ago
|
||
bringing back into nsbeta1+
Reporter | ||
Comment 15•24 years ago
|
||
moving to mozilla0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1
Comment 16•24 years ago
|
||
*** Bug 74872 has been marked as a duplicate of this bug. ***
Comment 17•24 years ago
|
||
Let me give this a try.
Comment 19•24 years ago
|
||
Reporter | ||
Comment 20•24 years ago
|
||
In 4.x at least we didn't remember this across sessions, just within the current
session. From looking at the code it seems that this remembers it after you
quit and shut down. I don't think it should do that since I still think users
will want to scroll to the first new message when starting up. I can't tell for
sure if this is the case so ignore me if it isn't.
Assignee | ||
Comment 21•24 years ago
|
||
putterman is right, the current patch will persist the last msg across sessions.
4.x had this? are we using the same pref that we used in 4.x?
suresh was going to persist the msg as an attribute in nsIMsgFolder, which makes
sense to me.
I've got a few other comments, I'll follow up soon.
Assignee | ||
Comment 22•24 years ago
|
||
3 things:
1) wrong pref, it looks like 4.x used "mailnews.remember_selected_message"
(can you confirm that using http://lxr.mcom.com)
if use the same pref, we do the right thing when the user migrates from 4.x
2) "var LastMsg", do "var lastMsg". for code readability, LastMsg looks like
function and not a variable.
3) instead of persisting the attribute in localStore.rdf (by persisting it as
an attribute on the folder content), add a string attribute to nsIMsgFolder for
the last message.
I need to think about the rest of the patch, but that should get you started.
Assignee | ||
Comment 23•24 years ago
|
||
do you plan on conditionally, or unconditionally setting the "last msg"
attribute on the nsIMsgFolder?
consider this case:
the user reads a message, changes the pref to "remember the last selected
message", then switches folder. if we conditionally set, we won't have
remembered the last message. we'd have to load another message before it
started to work.
you have three choices:
1) unconditionally remember the last message, but conditionally use it.
(simpler, but inefficient for users who aren't remember the last selected
message)
2) add a pref callback in our 3 pane JS, that gets fired
if "mailnews.remember_selected_message" gets changed. if it gets set to true,
set the current displayed message attribute on the nsIMsgFolder
(more complicated, but correct)
3) conditionally set and conditionally get, and log a bug on this issue and
specify the pref callback solution.
I'd suggest doing #3.
Assignee | ||
Comment 24•24 years ago
|
||
two more things
1) we shouldn't be persisting (within the session) the index or the uri. I
think we need to using the message id. index can change if messages are
deleted. we want to re select the last message, not the message in the same
place as the last message.
2)
we need to make sure we do the right thing for cross folder navigation (loading
the next unread) and provide the functionality that gayatrib needs to finish
the "Go To Folder" button in search. your patch will break cross folder
navigation.
to write the "FolderLoaded" handler correctly, you will have to clean up and
fix some code.
we should be doing this:
if the special global for message id is set, scroll to and select the exact
message. (search uses this). (null it out after using it.)
if that didn't work and the special global for type of navigation is set,
scroll and select that message. (null it out after using it.)
if that didn't work and the user has set the pref to remember the selected
message, scroll to and select the persisted message.
if that didn't work, scroll to, but don't select the first new message
if that didn't work, scroll to the top.
<end>
it's getting complicated, you should move logic out of the "FolderLoaded"
handler.
do you have what you need to turn message-id into index? you might have to
extend nsIMsgDBView.idl
Assignee | ||
Comment 25•24 years ago
|
||
search will have message uri but persistence will use a message id.
we can turn the message uri into a nsIMsgDBHdr and get the message id and then
use the same code to turn message id into index.
Comment 28•24 years ago
|
||
*** Bug 83472 has been marked as a duplicate of this bug. ***
Updated•24 years ago
|
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Comment 29•24 years ago
|
||
Adding myself to the list, I want to listen :)
Comment 30•23 years ago
|
||
*** Bug 96155 has been marked as a duplicate of this bug. ***
Comment 31•23 years ago
|
||
Seth - Is this worhty of a nsbranch+, and/or the 0.9.4 milestone?
Whiteboard: [nsbeta1+]
Assignee | ||
Comment 32•23 years ago
|
||
nope, not worthy.
Assignee: prass → sspitzer
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Assignee | ||
Comment 33•23 years ago
|
||
Comment on attachment 32497 [details] [diff] [review]
initial patch - store the message index on folder. The new one to store the URI and load folder coming up
bad patch, out of date and needs work.
Attachment #32497 -
Attachment is obsolete: true
Attachment #32497 -
Flags: needs-work+
Comment 35•23 years ago
|
||
*** Bug 107880 has been marked as a duplicate of this bug. ***
Comment 36•23 years ago
|
||
*** Bug 108442 has been marked as a duplicate of this bug. ***
Reporter | ||
Updated•23 years ago
|
Comment 37•23 years ago
|
||
*** Bug 109947 has been marked as a duplicate of this bug. ***
Comment 38•23 years ago
|
||
*** Bug 112717 has been marked as a duplicate of this bug. ***
Comment 39•23 years ago
|
||
*** Bug 100141 has been marked as a duplicate of this bug. ***
Comment 41•23 years ago
|
||
*** Bug 121044 has been marked as a duplicate of this bug. ***
Reporter | ||
Updated•23 years ago
|
Comment 42•23 years ago
|
||
*** Bug 123471 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 43•23 years ago
|
||
*** Bug 48120 has been marked as a duplicate of this bug. ***
Comment 44•23 years ago
|
||
*** Bug 126167 has been marked as a duplicate of this bug. ***
Comment 45•23 years ago
|
||
*** Bug 140260 has been marked as a duplicate of this bug. ***
Comment 46•23 years ago
|
||
*** Bug 142857 has been marked as a duplicate of this bug. ***
Comment 47•23 years ago
|
||
*** Bug 145643 has been marked as a duplicate of this bug. ***
Comment 48•23 years ago
|
||
*** Bug 146594 has been marked as a duplicate of this bug. ***
Comment 49•23 years ago
|
||
*** Bug 147921 has been marked as a duplicate of this bug. ***
Comment 50•23 years ago
|
||
*** Bug 153068 has been marked as a duplicate of this bug. ***
Comment 51•23 years ago
|
||
*** Bug 153966 has been marked as a duplicate of this bug. ***
Comment 52•23 years ago
|
||
*** Bug 157148 has been marked as a duplicate of this bug. ***
Comment 53•23 years ago
|
||
*** Bug 158611 has been marked as a duplicate of this bug. ***
Comment 55•23 years ago
|
||
*** Bug 160284 has been marked as a duplicate of this bug. ***
Comment 56•22 years ago
|
||
*** Bug 164726 has been marked as a duplicate of this bug. ***
Comment 57•22 years ago
|
||
*** Bug 164987 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 58•22 years ago
|
||
moving to 1.2beta.
Target Milestone: mozilla1.2alpha → mozilla1.2beta
Assignee | ||
Comment 59•22 years ago
|
||
I think either varada or ssu were going to help on this one.
Assignee | ||
Comment 60•22 years ago
|
||
varada's working on it.
Assignee: sspitzer → varada
Status: ASSIGNED → NEW
Comment 61•22 years ago
|
||
Commenting out UI for pref till the feature is implemented.
Assignee | ||
Comment 62•22 years ago
|
||
Comment on attachment 102262 [details] [diff] [review]
Changes to pref-mailnews.xul and pref-mailnews.dtd.
there is no need to comment out the .dtd items. the will jut be unused.
Attachment #102262 -
Flags: needs-work+
Reporter | ||
Updated•22 years ago
|
Assignee | ||
Comment 64•22 years ago
|
||
taking.
let's hope nsDBFolderInfo::GetLastMessageLoaded() and
nsDBFolderInfo::SetLastMessageLoaded() work, and do the hard parts for me.
Assignee: varada → sspitzer
Status: ASSIGNED → NEW
Target Milestone: mozilla1.2beta → mozilla1.3beta
Assignee | ||
Comment 65•22 years ago
|
||
1) only seems to work for the inbox (maybe other folders get closed, and the
dbinfo isn't getting written out, read back in?)
2) probably not setting last selected in the right place (this should be for 3
pane only, will stand alone msg view affect the last selected message?)
3) will dbinfo changes persist across sessions?
4) this patch selects and scrolls, need to verify that is desired (what did
4.x do?) and make sure I didn't break any existing functionality (open message
folder, next unread, etc)
Attachment #102262 -
Attachment is obsolete: true
Assignee | ||
Comment 66•22 years ago
|
||
I think I see why this only works for inbox.
we are missing
GetInt32PropertyWithToken(m_lastMessageLoadedColumnToken, m_lastMessageLoaded);
from nsDBFolderInfo::LoadMemberVariables()
we probably keep inbox folder open, but close the others (for footprint reasons)
so we keep creating dbfolderinfo, but never set m_lastMessageLoaded from what we
saved.
a fix would be
Status: NEW → ASSIGNED
Assignee | ||
Comment 67•22 years ago
|
||
ok, that fixes it, but now the last selected message persists across sessions,
which we don't want.
I think I'm going to have to remove that from dbinfo, and put it on nsIMsgFolder
and not persist on disk.
while the db can be unloaded, the folder won't be.
working on that fix now.
Assignee | ||
Comment 68•22 years ago
|
||
I still need to test for regressions, but the basics of this works.
the stand alone msg window mucks with the last selected message, because of
where I'm setting it. (I doubt we want that.)
if not, I'll find a new place to set the last selected message, that is 3 pane
only.
Attachment #109209 -
Attachment is obsolete: true
Assignee | ||
Comment 69•22 years ago
|
||
talked it over with bienvenu, he's given me some suggestions on how to improve
this patch.
Comment 70•22 years ago
|
||
Comment on attachment 109210 [details] [diff] [review]
patch
r/sr=bienvenu
Attachment #109210 -
Flags: superreview+
Assignee | ||
Comment 71•22 years ago
|
||
Attachment #109210 -
Attachment is obsolete: true
Assignee | ||
Comment 72•22 years ago
|
||
Comment on attachment 109236 [details] [diff] [review]
update patch, with bienvenu suggestions rolled in
carrying over sr=bienvenu from last patch.
Attachment #109236 -
Flags: superreview+
Assignee | ||
Comment 73•22 years ago
|
||
fixed.
any comments about the stand alone msg window affecting the last selected message?
the current might be desired.
to see the affect, do this:
1) open 3 pane, select message x, and double click to get stand alone msg window.
2) switch folders in 3 pane
3) in stand alone msg window, navigate to another message, y.
4) switch back to original folder. instead of x being selected, y is selected.
this is sort of an edge case.
if we think it's a bug, let's spin it off.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 74•22 years ago
|
||
Awesome Seth!!! whooo hoooo!!!!
Comment 75•22 years ago
|
||
I think this bug has had some unintended side affects.
With 1213 build, win2k, in three pane view, with the focus in the message index,
using the up/down arrow keys does what you would generally expect, ie, moves up
and down through the index.
With 1214 build, the up down arrow key will move up/down by one message, but
focus will then immediately change to the message pane.
With 1217 build of course, this is gone again, but I can't work what fixed it
exactly. :(
Cheers,
Karl P
Comment 76•22 years ago
|
||
The problems described in comment 75 where propably caused by the fix to bug
110718 which was backed out.
Comment 77•22 years ago
|
||
This check-in created a few very annoying side-effects:
- when a folder with new messages is selected (in folders pane), the headers
panes is scrolled to a position where no new headers are visible (so I have to
scroll before being able to read new messages).
- if I mark a selected message as unread before leaving a folder (something I
almost always do when briefly browsing new messages), then when I come back to
the folder, the message is selected again, automatically marked read again, and
I have to keep marking it unread *every time*.
Filed bug 186504 on these issues.
Comment 78•22 years ago
|
||
OK using 2003-01-13 commercial trunk: win98, linux rh8.0 mac OS 10.2
Basics working and tested in mail (general POP and IMAP) and news accounts, a
few different view settings, 3-pane and standalone navigation. Tested that pref
works to enable/disable this feature. Not all scenarios tested -- will log any
issues found as separate bug report(s).
Marking this verified.
Status: RESOLVED → VERIFIED
Comment 79•22 years ago
|
||
*** Bug 195319 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•