Closed Bug 109959 Opened 23 years ago Closed 13 years ago

Site icons (favicons) disappear in url bar [reload, following link to a page on the same site, etc]

Categories

(SeaMonkey :: Location Bar, defect)

Product:
SeaMonkey
Component:
Location Bar
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: tpowellmoz, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

In Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.5+) Gecko/20011112
nightly build, when first you go to a page with an icon specified using the link
rel="icon" command, the icon shows up. However if you reload the page or go to
the URL box and press Enter it disappears and is replaced by the default
bookmark icon.

I first saw this problem with bugzilla. This may be a problem with non
.ico-based site icons (bugzilla uses a .png).
Of course now I can't get it to show up at all... it's always the default
bookmark icon. Drat!

I should mention that I have both the browser.chrome.siteicon and
browser.chrome.favicon prefs enabled and they are generally working.

http://www.evolt.org/ also uses link rel to specify the icon and it seems to
work basically correctly. A reload causes the default bookmark icon to appear
and then be replaced by site icon.
Looks like there's some problems--now evolt won't show the site icon either. :-(
It looks like the icon fairly consistently loads the first time when doing Open
in New Window. All bets are off on reloads.
wfm with win2k build 20011112..
wfm on slightly older build 2001-11-10, linux
I'm seeing the problem: 2001111603 Win98

The problem also occurs when moving from one page to another with the same icon
via a link on the page.  For example, click right here -> bug 100000

It does happen with .ico files too, because I've noticed it on the site I'm
working on.  It seems to only happen on sites that specify it via a link tag,
rather than those that put favicon.ico at the root of the site.
I see it too.  20011117 build, win2k.

I think favicon's is one of hyatt's babies.  over to him.
Assignee: asa → hyatt
Ok, I just installed Mozilla 0.9.6 on Windows 2000 (as Administrator).
Running now as PowerUser (I don't know if it makes a difference for this)

The Favicons are only appearing at some instances. For example, I get the icon
with these sites:
http://www.mozilla.org/
http://bugzilla.mozilla.org/
http://www.anandtech.com/

But then with others like
http://www.slashdot.org/
http://www.mozillazine.org
http://www.cnn.com
http://www.hotmail.com

the icon is the default one. I can't seem to pin-point when it works and when it
doesn't, but it certainly doesn't work as well as on today's (Nov21 I believe)
nightly version for W98 where I was getting all icons properly.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.1
*** Bug 111756 has been marked as a duplicate of this bug. ***
bug 111756 has valuable info to this bug.
-This problem seems to happen with sites that use <LINK>
-There is a table on that bug that shows the behaviour on different image formats
To summarize and generalize the information from bug 111756:
(checked again using 2001120908 on W2K)

* The problem of the disappearing icon only happens when the <link/> elements
"icon" and/or "shortcut icon" are used in the <head/> of a page; it does not
happen on sites using a favicon.ico.

* The disappearance of the site icon upon reload happens if:
  1) Only "icon" or only "shortcut icon" is defined as a <link/> element.
  2) If both "icon" and "shortcut icon" are defined in one file, the problem
     appears if both refer to the same graphics file.
     If, OTOH, they refer to two different graphics files then the problem does
     not occur. The file type of the two files (as speculated in 111756) is
     irrelevant, as long as two files are used. The files can be file1.png and
     file2.png that are exact copies of each other.
     Checked with png, gif and ico.


*** Bug 115503 has been marked as a duplicate of this bug. ***
QA Contact: doronr → claudius
I don't know if this is the right place for this, but it seemed the best place
to add a comment.
For me in mozilla-0.9.7 everything works fine, the icons all appear in tabs,
URLbar and bookmarks. The only thing is that they vanish after I restarted the
system. Aren't they supposed to stay?
BTW I have the same problem as Daniel Steinberger... They just dissaper...
*** Bug 116832 has been marked as a duplicate of this bug. ***
*** Bug 116914 has been marked as a duplicate of this bug. ***
*** Bug 116912 has been marked as a duplicate of this bug. ***
For additional data, it shows up in 0.9.7 Build 2001122106 running under Windows
ME. All icons disappear in the bookmarks folder. It seems to be a standard bug
under Windows; haven't tested under Linux yet, as Linux PPP connections are
nonfunctional on this computer.
Very similar problem with Build 2001122106 (Win98, german):
Icons do show up initially, although sometimes after restart only. But they
disappear after one or two days. It is as if they were stored in the disk cache
and not in a permanent place. It would be nice to fix this bug for the 1.0 release. 
It seems there is some confusion of at least two bugs going on here. Favicons
not appearing in *sidebar* *at all* (at least on some OS) is bug 113574.
Favicons not appearing in bookmark *toolbar and menus* until the site is visited
again after restart is this bug.

P.S. Sometimes I have some bookmarks show up with favicons in toolbar of one
Mozilla window and without favicons in toolbar of another Mozilla window. This
is probably just another side effect of this bug.

P.P.S. I run 0.9.7 on RedHat Linux 7.2 and I never see favicons in bookmarks
sidebar and I only see them in toolbar after I visit a particular site (e.g. I
do not have any favicons right after restart).
OS: Windows 2000 → All
So after comment #13 this bug got completely off its track. It is not about the
favicons randomly disappearing upon restarting Mozilla, but upon reloading the
current page during the same session (summary analysis see comment #11).

I am changing the summary to clarify this, and will reopen "dup" bug 116832 
to adress the problem of favicons disappearing upon restarting Mozilla.
Summary: favicon (site icon) disappears after reload → favicon (site icon) disappears after reloading page in same session
One more clarification: This bug is about the favicon shown in the
url/navigation bar, bug 116832 (no reopened) is about the favicon in bookmarks
and personal toolbar.
Summary: favicon (site icon) disappears after reloading page in same session → favicon (site icon) in url bar disappears after reloading page in same session
It seems there is still come confusion between several favicon bugs. The way I
understand it, we have (at least) 3 different bugs.

Bug 109959 deals with favicon in the *url bar*. The problem usually manifests in
favicon disappearing on *page reload* and sometimes not appearing when already
visited page is revisited.

Bug 113574 deals with favicons in bookmarks *sidebar and management window*. For
some people (including myself), favicons *no longer appear there at all, no
matter what we do*. According to the initial reporter, this may be caused by
"conversion to <outliner> which just landed"

Finally, bug 116832 deals with favicons in bookmarks *personal toolbar and menu*
- there the problem is that the favicons are not displayed when Mozilla is
started (even if the bookmarks file contains them) and only appear when the site
is visited again. It also seems that sometimes some favicons would not appear in
toolbar and menus of a newly opened browser window even though they appear in an
older window.

-----

Did I get it right this time?

Is it time to create a tracking bug to help avoid confusing different issues?
On this page:

http://www.ibmpcug.co.uk/~irdial/blogger.html

The favicon.ico appears the first time the page is loaded. When you reload the
page, it is replaced with the standard icon. This happens every time for me.

Im running win98 0.9.7 build 2001122106
Blocks: 120352
Is this the same as bug 118951?
*** Bug 118951 has been marked as a duplicate of this bug. ***
Depends on: 113430
Currently, this bug is set to depend on byg 113430. That bug is a meta bug,
however. This bug seems to block bug 113430 instead. Thus, changing this bug to
block bug 113430.
No longer depends on: 113430
Blocks: 113430
No longer blocks: 120352
Target Milestone: mozilla1.1 → Future
Could someone test the patch in comment 14 of bug 113798 to check if it really
fix this bug ?
Blocks: 120352
*** Bug 128872 has been marked as a duplicate of this bug. ***
Renaming some bugs to cut down on confusion, per comment 17.  Dropped the
"reload" part because the bug is broader than that, per comment 6.
Summary: favicon (site icon) in url bar disappears after reloading page in same session → Site icons (favicons) disappear in url bar
*** Bug 109112 has been marked as a duplicate of this bug. ***
...make that comment 23 for confusion.
Summary: Site icons (favicons) disappear in url bar → Site icons (favicons) disappear in url bar [reload, following link to a page on the same site, etc]
Incidentally attachment 94708 [details] [diff] [review] to bug 113202 also fixes this.
Depends on: 113202
It seems that if an iframe reloads, even if the favicon is also specified in the
iframe, the favicon disappears after successfully loading when first visiting
the page.  This can be scene by putting an iframe on the page and forcing it to
reload with javascript or meta tags.
This works for me in Mozilla 1.4b-20030502. However, it still looks broken in
Phoenix/Firebird 20030504. Bug #204393 has a testcase that accidentally
demonstrates the bug in Phoenix/Firebird.
Oh, it still not fixed yet.
Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4b) Gecko/20030517 builds has same bug.
Try to reload http://www.mozilla.org

*** Bug 222822 has been marked as a duplicate of this bug. ***
Still present in today's Linux CVS trunk build.

Bug 228042 was filed today on the observation that pressing ESC with the
location bar focused also makes the icon disappear - I strongly believe this is
a duplicate, but I left it open for now to get confirmation.
*** Bug 228294 has been marked as a duplicate of this bug. ***
*** Bug 228042 has been marked as a duplicate of this bug. ***
From duped bug 228294 and 228042: opening a second tab and pressing ESC on a
focused address bar can also make favicons disappear.

Steps to Reproduce:
1.open new browser window, no tabs.
2.go to site with a favicon.ico or 'link rel="icon"' icon
3.open new tab in this window. icon disappears from tab and from location bar
(4.if loading a site with icon in new tab, its icon appears fine)

Actual Results:  
The favicon in the first tab disappears.

and:

Steps to Reproduce:
1.open http://www.mozilla.org/ the favicon logo
2.place cursor inside the address bar (alt-d or by clicking inside the text box)
3.Press ESC key

Actual Results:  
the small mozilla logo left to the URL disappears and the default bookmark icon
appears.
This bug shows up as soon as set in all.js

pref("browser.chrome.favicons", true); (instead of false).

After this setting site icons (not favicons!) disappear after reload or
after navigating in the site.
Example is http://www.mozilla.org .

Without the above setting it looks OK (???).
Flags: blocking1.7?
Flags: blocking1.7? → blocking1.7-
(In reply to comment #11)
> To summarize and generalize the information from bug 111756:
> (checked again using 2001120908 on W2K)
> 
> * The problem of the disappearing icon only happens when the <link/> elements
> "icon" and/or "shortcut icon" are used in the <head/> of a page; it does not
> happen on sites using a favicon.ico.
> 
> * The disappearance of the site icon upon reload happens if:
>   1) Only "icon" or only "shortcut icon" is defined as a <link/> element.
>   2) If both "icon" and "shortcut icon" are defined in one file, the problem
>      appears if both refer to the same graphics file.
>      If, OTOH, they refer to two different graphics files then the problem does
>      not occur. The file type of the two files (as speculated in 111756) is
>      irrelevant, as long as two files are used. The files can be file1.png and
>      file2.png that are exact copies of each other.
>      Checked with png, gif and ico.
> 
> 

Based on this comment, I tried adding

<LINK REL="SHORTCUT ICON" HREF="redmc.ico" type=”image/x-icon”>
<LINK REL="ICON" HREF="favicon.ico" type=”image/x-icon”>

to my <head>, where redmc.ico and favicon.ico are identical files with different
names.  No change in behavior occurred.  I see the favicon if I open the image,
but it disappears if another tab is opened.
(In reply to comment #43)
> (In reply to comment #11)
> > To summarize and generalize the information from bug 111756:
> > (checked again using 2001120908 on W2K)
> > 
> > * The problem of the disappearing icon only happens when the <link/> elements
> > "icon" and/or "shortcut icon" are used in the <head/> of a page; it does not
> > happen on sites using a favicon.ico.
> > 
> > * The disappearance of the site icon upon reload happens if:
> >   1) Only "icon" or only "shortcut icon" is defined as a <link/> element.
> >   2) If both "icon" and "shortcut icon" are defined in one file, the problem
> >      appears if both refer to the same graphics file.
> >      If, OTOH, they refer to two different graphics files then the problem does
> >      not occur. The file type of the two files (as speculated in 111756) is
> >      irrelevant, as long as two files are used. The files can be file1.png and
> >      file2.png that are exact copies of each other.
> >      Checked with png, gif and ico.
> > 
> > 
> 
> Based on this comment, I tried adding
> 
> <LINK REL="SHORTCUT ICON" HREF="redmc.ico" type=”image/x-icon”>
> <LINK REL="ICON" HREF="favicon.ico" type=”image/x-icon”>
> 
> to my <head>, where redmc.ico and favicon.ico are identical files with different
> names.  No change in behavior occurred.  I see the favicon if I open the image,
> but it disappears if another tab is opened.

Oops: I see the favicon if I open my site in a new browser instance, but opening
a tab eliminates it.
*** Bug 251178 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
This has been fixed with the check-in for bug 109672, right?
Oh, bug 109672 is fixed in Firefox only. Sorry.
Is anyone still seeing this with a recent build?  I think the site icon issues got worked out a while back.
Assignee: hyatt → location-bar
Status: ASSIGNED → NEW
Component: General → Location Bar
Product: Mozilla Application Suite → Core
QA Contact: claudius
Target Milestone: Future → ---
I'm guessing this is fixed now, could someone test with a Seamonkey trunk build?
Product: Core → SeaMonkey
I think I'm still seeing this with Google reader.

Steps to reproduce:
(Prefs: Show website icons: Yes; aggressively look for website icons: No; [*] Always load web site icons for bookmarks)
1) Ensure that you can see tabs (open 2 tabs or don't hide on a single tab)
2) Visit Google Reader (needs account)
3) Observe that both the tab and the location bar favicon show the "RSS" style favicon
4) Click on a feed in the left hand side

Expected results: nothing changes with the favicons
Actual results: the favicon in the location bar changes back to the default (if "aggressively look for website icons" is set to true then the default Google icon replaces the RSS icon rather than the default icon).
Closing as WORKSFORME based on code comparison with Firefox tabbrowser vide bug 109672.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.