This covers the implementation of NS_THEME_TAB and NS_THEME_TAB_PANEL for XUL tab panels on Windows.

This patch adds support for tabs. It doesn't yet cover tabpanels, because I have to write some custom code to handle not drawing a line under the tab itself. A known issue is called out in the bug, namely that I have no way of knowing how thick the "edges" of tabs are, since all of the skins I tried don't properly return content margins. This means I'm forced to make an unfortunate assumption about the thickness of an edge (namely that the edge of a tab is 2 pixels thick).

IMO the skins themselves are buggy here, but since they're all behaving this way (probably following a bad pattern set by Luna), there isn't much I can do.

Comment on attachment 63620 [details] [diff] [review] Patch to add support for tabs. sr=blake

Comment on attachment 63620 [details] [diff] [review] Patch to add support for tabs. r=bryner

Fix checked in. Now all I have left is the tab panel.

Tabpanels support. Known issues: handling not drawing the line under the selected tab, line needs to overlap tabs by one pixel in order to be pixel-perfect, and finally no way to specify a tabpanel (which isn't really a big deal, the style builder doesn't even show you this as a separate entity in the widget display).

Comment on attachment 63691 [details] [diff] [review] Patch to add support for tabpanels. r=bryner

Comment on attachment 63691 [details] [diff] [review] Patch to add support for tabpanels. sr=blake

Ok, marking this fixed. Will file separate bugs for the remaining drawing issue.

david, did this fix cause bug 118471 to be exposed?