Closed Bug 117584 Opened 23 years ago Closed 10 years ago

NS_THEME_* implementations (meta bug)

Categories

(Core Graveyard :: Skinability, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ian, Unassigned)

References

(Depends on 4 open bugs)

Details

(Keywords: meta, Whiteboard: [Hixie-CSSUI2])

Attachments

(1 file)

Blocks: 39375
hyatt: Why no NS_THEME_MENUBAR, NS_THEME_MENU_POPUP and NS_THEME_MENUITEM?
There should be. Add bugs. :)
Depends on: 118024
Depends on: 118025
Ok, bug 118024 and bug 118025 filed. Note that those constants are not currently defined. This might mean the Windows XP theme API does not have a way to get to them, I don't know how you made the list.
No longer depends on: 118024, 118025
Depends on: 118292
Depends on: 118293
Depends on: 118312
Depends on: 118310
Depends on: 118309
Depends on: 118307
Depends on: 118306
Depends on: 118304
Depends on: 118302, 118303
Depends on: 118295
Depends on: 118025
Depends on: 118294
Depends on: 118308
Depends on: 118301
Depends on: 118299
Depends on: 118298
Depends on: 118297
Depends on: 118296
Depends on: 118024
Attached image mac osx progress (deleted) —
a screenshot of how far i've gotten on mac
Depends on: 119737
Depends on: 119736
Depends on: 119735
Blocks: 98995
Blocks: 74292
Depends on: 118290
Depends on: 115462
I think we need a way to distinguish between simple push buttons that only contain text and are of normal size and push buttons that are oversized or contain icons. On the mac, the former corresponds to simple buttons and the latter corresponds to bevel buttons. Two buttons that should be bevel buttons on the mac are the 'Search' and 'M' buttons in Navigator toolbar. This issue will become more important once xbl form controls are implemented because buttons created with the input tag should be regular buttons and buttons created with the button tag should be bevel buttons.
yup, i totally agree. i've been thinking that for a while, just haven't done anything about it ;)
I'm not sure I like the claim that <input type="button" value="hello"> will look different from <button>hello</button>. As a webdesigner (well, a programmer that works on server-side web development and thus ends up writing a lot of website code), that's not what I'd expect, and it'd be even more unexpected if windows and/or linux made no such distinction. Since I don't know much about OSX, I'm not sure how great of a difference there is between the two button types, but I'd like to see some justification of the claim that the two ways of creating buttons in html should look different (and on mac only, even!).
we're talking about chrome, not html ;)
Actually there is a precedent in the HTML standard for button elements being drawn differently from input elements: http://www.w3.org/TR/html4/interact/forms.html#h-17.5 "Visual user agents may render BUTTON buttons with relief and an up/down motion when clicked, while they may render INPUT buttons as "flat" images." Although button and input tags would not be distinguished in the way described in the standard, they would be distinguished in a different way that is consistent with the mac look and feel.
Whiteboard: [Hixie-CSSUI2]
Do we need NS_THEME_* implementation for the activity icon? (The spinning arrows seen on Modern's tabs during load, for example.)
Depends on: 185435
*** Bug 74292 has been marked as a duplicate of this bug. ***
Hmm, should bug 174471 be in the dependencies here?
How about adding helpwanted keyword here? Some of the remaining implementations should be easy (just more of the same) and would greatly improve the UI. I've been looking at the code and it seems like the menu part should be trivial (WinXP). Mostly copy and paste. Unfortunately my Mozilla dev environment is broken at the moment. I'll see if I can get it working anytime soon to see if this is as easy as I think it is.
Filter on "Nobody_NScomTLD_20080620"
QA Contact: pmac → skinability
Product: Core → Core Graveyard
This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX. [Mass-change filter: graveyard-wontfix-2014-09-24]
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: