Exchange AutoDiscover and addon setup in account creation dialog
Categories
(Thunderbird :: Account Manager, enhancement, P1)
Tracking
(thunderbird_esr6065+ fixed, thunderbird65 fixed, thunderbird66 fixed)
People
(Reporter: BenB, Assigned: BenB)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Attachments
(2 files, 4 obsolete files)
(deleted),
text/x-phabricator-request
|
jorgk-bmo
:
approval-comm-beta+
|
Details |
(deleted),
patch
|
jorgk-bmo
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 9•6 years ago
|
||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Comment 12•6 years ago
|
||
Assignee | ||
Comment 13•6 years ago
|
||
Comment 14•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 15•6 years ago
|
||
Assignee | ||
Comment 16•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 17•6 years ago
|
||
Comment 18•6 years ago
|
||
Updated•6 years ago
|
Comment 19•6 years ago
|
||
Assignee | ||
Comment 20•6 years ago
|
||
Comment 21•6 years ago
|
||
Comment 22•6 years ago
|
||
Comment 23•6 years ago
|
||
Comment 24•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 25•6 years ago
|
||
Comment 26•6 years ago
|
||
Comment 27•6 years ago
|
||
Comment 28•6 years ago
|
||
Comment 29•6 years ago
|
||
Comment 30•6 years ago
|
||
You're making this a little painful :-(
Ben told me to get the patches from this try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a141ab4f4e83bdaba447e4a0a330fc61311821b3
So I'm comparing D14408 here to https://hg.mozilla.org/try-comm-central/rev/df29a6d4527c977595099ce46e6dd902d2ca1599 and they are quite different :-( - Most strikingly, the try changeset has string changes:
mail/locales/en-US/chrome/messenger/accountCreation.dtd
mail/locales/en-US/chrome/messenger/accountCreation.properties
Please provide proper HG patches or somewhere to get them from. This try run can't be it.
I'll stop here now since if I can't land the base patch, there's nothing to do right now.
Updated•6 years ago
|
Comment 31•6 years ago
|
||
And can you please provide all patches with 8 lines context so I can compare them. It's tedious to apply them, refresh them, then apply the other one, refresh it and then finally compare :-(
Assignee | ||
Comment 32•6 years ago
|
||
Most strikingly, the try changeset has string changes
Yes, that's a mistake, D14408 does not, Neil must have picked the wrong patch. Sorry that I didn't catch that.
Comment 33•6 years ago
|
||
I'm sorry for my mistake, I'll redo the Try run with the correct patch this time...
Comment 34•6 years ago
|
||
Assignee | ||
Comment 35•6 years ago
|
||
I'm testing it, and I've got an error. Investigating.
Please don't merge yet.
Assignee | ||
Comment 36•6 years ago
|
||
I found a small problem with an API change: Services.locale.getRequestedLocale() on ESR60 instead of .requestedLocale on trunk. Otherwise, it works.
I've tested it and it works as expected.
Assignee | ||
Comment 37•6 years ago
|
||
(with HG header, manually created, I hope it works)
Assignee | ||
Comment 38•6 years ago
|
||
(...and -U8 context 8 lines)
Assignee | ||
Updated•6 years ago
|
Comment 39•6 years ago
|
||
(In reply to Ben Bucksch (:BenB) from comment #36)
I found a small problem with an API change: Services.locale.getRequestedLocale() on ESR60 instead of .requestedLocale on trunk. Otherwise, it works.
I knew that ;-) - How's the state of the other patches? I can see two try runs
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=31538f4ad208dce05f259a8ae38a74c9b5a4b118
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=eeb49d8b015520455369ddf697b2fd0e86a646d6
BTW, they do include the "bold" bug.
Assignee | ||
Comment 40•6 years ago
|
||
they do include the "bold" bug.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=eeb49d8b015520455369ddf697b2fd0e86a646d6
does not include the "domain bold" patch. I've verified that in:
https://hg.mozilla.org/try-comm-central/file/eeb49d8b015520455369ddf697b2fd0e86a646d6/mail/components/accountcreation/content/emailWizard.js#l965
It does include the patch for this bug, even though it does not show in the list, because the identical patch has in the first try build and hg then doesn't show it, but it's in this try build:
https://hg.mozilla.org/try-comm-central/file/eeb49d8b015520455369ddf697b2fd0e86a646d6/mail/components/accountcreation/content/exchangeAutoDiscover.js
The domain bold bug is optics only, has nothing to do with Exchange, and is optional, we can leave it out.
I've tested all the patches (aside from the domain bold patch) together in a build, ran my standard manual tests, and they all work fine, as far as I could see.
Comment 41•6 years ago
|
||
My mistake, ...b118 had the bold patch, and for ....46d6 I incorrectly assumed I had, too. Sorry.
Comment 42•6 years ago
|
||
OK, so for the record: We go with the ESR60 patch here, plus the five changesets from
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=eeb49d8b015520455369ddf697b2fd0e86a646d6
As discussed, they don't include the "bold" thing ;-)
Right?
Assignee | ||
Comment 43•6 years ago
|
||
Right.
Once you merged it, we can test the builds.
Comment 44•6 years ago
|
||
Comment 45•6 years ago
|
||
TB 60.5.0 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/c728c1579f04d8c596c1224dc62ef1e6cd39cae6
Assignee | ||
Comment 46•6 years ago
|
||
Thanks so much for merging this! This is a huge relieve for me!
I've downloaded the TB 60.5 build
treeherder: https://treeherder.mozilla.org/#/jobs?repo=comm-esr60&revision=acaf08e72ead14783d06d0cd8f14431b31ba3b97&selectedJob=223017085
Linux: https://queue.taskcluster.net/v1/task/DCetzb2GRWqQT5A_x3LK9Q/runs/0/artifacts/public/build/target.tar.bz2
and tested it, and it all works as expected.
Most accounts (even outlook.com etc.) have IMAP configs in our ISPDB, and they are still give IMAP configs as expected.
To emulate hosted on-premise Exchange servers for small domains, I disabled the ISPDB (see comment 7), and then we detect the AutoDiscover and everything works as expected. I tried 5 Exchange accounts on different servers, and they all were properly detected, automatically configured, and worked.
If you do happen to find something catastrophically wrong, please add it to bug 1514627 (alias exchange-meta). I will stand by in ready mode and will try to fix any severe and real problems that might be found right away.
Updated•5 years ago
|
Updated•5 years ago
|
Description
•