Closed Bug 1699663 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28149 - Revert "[AspectRatio] Fix flex-aspect-ratio-026.html in legacy"

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28149 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28149
Details from upstream follow.

b'Rob Buis <rbuis@igalia.com>' wrote:

Revert "[AspectRatio] Fix flex-aspect-ratio-026.html in legacy"

This reverts commit 174c8fdaa25c49ca36b702598f3fc08f72cc4f29.

Reason for revert: see https://github.com/w3c/csswg-drafts/issues/6071#issuecomment-801338121

Original change's description:

[AspectRatio] Fix flex-aspect-ratio-026.html in legacy

Implement min/max size transfers for replaced elements:
https://drafts.csswg.org/css-sizing-4/#aspect-ratio-size-transfers

Mark both flex-aspect-ratio-025.html and flex-aspect-ratio-026.html as
passing for legacy and update these tests to take both main and cross
size padding into account.

Add flex-aspect-ratio-027.html to verify that min/max-size transfer does not always happen just because aspect-ratio is present.

Bug: 1164135
Change-Id: I20a26cbe256ae5d6a66c5763c7b12f814a3d7ef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2721723
Commit-Queue: Rob Buis \<rbuis@igalia.com>
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859812}

Bug: 1164135
Change-Id: I6a36d40c7e74eed6ab333a5bebcf6d1471d7d1b1

Reviewed-on: https://chromium-review.googlesource.com/2773267
WPT-Export-Revision: ebcf2d1fb712dad0d63280490d37345dbf0909ba

Component: web-platform-tests → Layout
Product: Testing → Core
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.