Closed Bug 1701367 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28266 - Streams: test whether canceling both branches in sequence with delay works

Categories

(Core :: JavaScript Engine, task, P4)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28266 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28266
Details from upstream follow.

b'Mattias Buelens <mattias@buelens.com>' wrote:

Streams: test whether canceling both branches in sequence with delay works

Accompanies whatwg/streams#1118.

Component: web-platform-tests → JavaScript Engine
Product: Testing → Core
Blocks: streams-meta

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 24 subtests

Status Summary

Firefox

OK : 4
PASS : 92
FAIL : 4

Chrome

OK : 4
PASS : 80
FAIL : 16

Safari

PASS : 51
FAIL : 21
ERROR: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/streams/readable-streams/tee.any.js: SKIP (Chrome: SKIP, Safari: SKIP)
/streams/readable-streams/tee.any.worker.html
ReadableStream teeing: failing to cancel when canceling both branches in sequence with delay: FAIL (Chrome: PASS, Safari: FAIL)
/streams/readable-streams/tee.any.serviceworker.html
ReadableStream teeing: failing to cancel when canceling both branches in sequence with delay: FAIL (Chrome: PASS, Safari: FAIL)
/streams/readable-streams/tee.any.sharedworker.html
ReadableStream teeing: failing to cancel when canceling both branches in sequence with delay: FAIL (Chrome: PASS)
/streams/readable-streams/tee.any.html
ReadableStream teeing: failing to cancel when canceling both branches in sequence with delay: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/streams/readable-streams/tee.any.js: SKIP (Chrome: SKIP, Safari: SKIP)

Blocks: 1702636
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e0dcbe48823 [wpt PR 28266] - Streams: add test for canceling both tee'd branches in sequence with delay, a=testonly https://hg.mozilla.org/integration/autoland/rev/e24f80ebb9c3 [wpt PR 28266] - Update wpt metadata, a=testonly

You can land https://phabricator.services.mozilla.com/D110657 together with the wpt update, which fixes this issue.

Flags: needinfo?(james)
Flags: needinfo?(james)
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/807515c043b1 [wpt PR 28266] - Streams: add test for canceling both tee'd branches in sequence with delay, a=testonly https://hg.mozilla.org/integration/autoland/rev/661c9c9fb65a [wpt PR 28266] - Update wpt metadata, a=testonly

Like I said in comment 6, my patch D110657 doesn't fix this issue.

Flags: needinfo?(evilpies)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ed9d7d798f93 [wpt PR 28266] - Streams: add test for canceling both tee'd branches in sequence with delay, a=testonly https://hg.mozilla.org/integration/autoland/rev/8cb30294d82e [wpt PR 28266] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f39512dcf14 [wpt PR 28266] - Streams: add test for canceling both tee'd branches in sequence with delay, a=testonly https://hg.mozilla.org/integration/autoland/rev/0dc116fb6378 [wpt PR 28266] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8f39512dcf14
https://hg.mozilla.org/mozilla-central/rev/0dc116fb6378

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Yaay. Seems like wpt updated are working again.

Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.