Open Bug 302609 Opened 19 years ago Updated 2 years ago

right-click on message in search messages (advanced) results should show contextual menu

Categories

(Thunderbird :: Mail Window Front End, enhancement)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
enhancement

Tracking

(thunderbird_esr78?)

Tracking Flags:
Tracking Status
thunderbird_esr78 ? ---

People

(Reporter: mozillauser, Assigned: mkmelin, NeedInfo)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [patchlove])

Attachments

(2 obsolete files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6 right-click on message in search results should display right-click-type menu options (e.g., open, open message folder, delete) - may be related (mine's more specific) to bug #262012 BTW, I'm using Thunderbird version 1.0.6 (20050716) on Windows XP Pro Reproducible: Always Steps to Reproduce: 1. Edit | Find | Search messages 2. enter criteria that result in at least one matching message 3. right-click on any resulting message 4. nothing happens (but should allow right-click-type menu options corresponding to actions listed on buttons at bottom of screen) Actual Results: nothing Expected Results: should allow right-click-type menu options corresponding to actions listed on buttons at bottom of screen
Suite bug 66970. Not really part of 262012. That bug suggests the menu provide: Open Message, Move Message, Copy Message, Delete Message -and- Label Message The buttons on the bottom of the dialog provide Open, Move ("File"), Delete, as well as Open Folder and Save as Search Folder; maybe those first three buttons could be removed if this menu were provided. I would like to see Flag as part of the menu as well, which could be as useful as Label (more so if/when more Flag support is provided).
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → Trunk
Summary: right-click on message in search results should display right-click-type menu options → right-click on message in search results should display right-click-type context menu
*** Bug 363958 has been marked as a duplicate of this bug. ***
"recent" folders should also be on the context menu for move and copy. And thinking bigger ... Search messages is touted as the powerful cousin to quick search (and at times its availability is even offered as reason that quick search need not be improved in certain directions). So isn't it counterintuitive that the UI and message handling functionality of the (powerful) search results pane is so suboptimal/regressive?
Component: General → Message Compose Window
QA Contact: message-compose
Summary: right-click on message in search results should display right-click-type context menu → right-click on message in search messages (advanced) results should display right-click-type context menu
Component: Message Compose Window → Mail Window Front End
QA Contact: message-compose → front-end
Flags: wanted-thunderbird3?
Assignee: mscott → nobody
Blocks: 347957
Assignee: nobody → mkmelin+mozilla
Flags: wanted-thunderbird3? → wanted-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b4
Attached patch proposed fix - wip (obsolete) (deleted) — — Splinter Review
Needs cleanup, but mostly working
Target Milestone: Thunderbird 3.0b4 → Thunderbird 3.1b2
I've been unbitrotting this patch these few days, it's quite rotted in some places. Should have a new patch soon.
Attached patch unbitrotted patch (obsolete) (deleted) — — Splinter Review
unbitrotted patch, most changes have mostly been ported except the ones in mailWindowOverlay and nsContextMenu, which have changed significantly and which I skipped, nothing done sans unbitrotting.
Attachment #531954 - Flags: superreview?(dbienvenu)
Attachment #531954 - Flags: review?(mkmelin+mozilla)
Comment on attachment 531954 [details] [diff] [review] unbitrotted patch ludo mentions that sr is for API changes only, so cancelling sr, but extra feedback would be nice. :)
Attachment #531954 - Flags: superreview?(dbienvenu) → feedback?(sid.bugzilla)
Comment on attachment 531954 [details] [diff] [review] unbitrotted patch I don't think i'm a suitable reviewer as i wrote the original patch. I can't recall exactly what but there were still a bunch of things to sort out there. (And now if you didn't unbitrot all of the patch, it's not likely to work.)
Attachment #531954 - Flags: review?(mkmelin+mozilla)
Attachment #531954 - Attachment is obsolete: true
Attachment #531954 - Flags: feedback?(sid.bugzilla)
Whiteboard: [patchlove]
Summary: right-click on message in search messages (advanced) results should display right-click-type context menu → right-click on message in search messages (advanced) results should show contextual menu
Target Milestone: Thunderbird 3.1b2 → ---
Blocks: 686851
Blocks: 780461

Magnus, any possibility to finish the patch here?

Flags: needinfo?(mkmelin+mozilla)

Alex, do you have cycles to polish off a patch? It would be a nice addition to 78

Flags: needinfo?(mkmelin+mozilla) → needinfo?(alessandro)

I'm not sure I have the capacity this week.
I'll try to find a slot later next week, talk to Magnus about it, and take a look at the uploaded patch.

Flags: needinfo?(alessandro)

Looking at the patch again a) I don't see any strings so I guess this doesn't need to happen before string freeze b) I missed some earlier comments about unfinished business "most changes have mostly been ported except the ones in mailWindowOverlay and nsContextMenu, which have changed significantly and which I skipped,"

I'll try to find a slot later next week, talk to Magnus about it, and take a look at the uploaded patch.

Thanks

Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(alessandro)

I'll take care of this patch during this week, if that's okay with Magnus, of course.

Flags: needinfo?(alessandro)

I became also curious how the support will evolve further for actions which can be offered by context menus for search results.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: