A proposal: set "Allow antivirus clients to quarantine individual incoming messages" ON by default because for some users in some cases it may appear that TB has deleted all messages in Inbox, but is antivirus that has put them in quarantine. One example of this is the bug #506265.

Probably should ifdef it to be on by default only on windows though.

I think we likely want this to be set in mailnews.js instead (to make it true both for tb and sm). Would also be nice to add the else clause for non-windows, so the pref is findable in the config editor. And add a comment on what it does there too. bienvenu might recall why it's not on by default...

iirc, some filter actions don't work with quarantining turned on (i.e., there are bugs with quarantining). I wouldn't turn it on without fixing those bugs first. WADA has been involved with those bugs and can probably find them easily.

Comment on attachment 391292 [details] [diff] [review] Proposed Fix Minusing per previous comments

Wada could you list the bugs involving having this pref on please ?

Comment on attachment 391292 [details] [diff] [review] Proposed Fix Obsoleting as this pacth should go to mailnews.js.

David, are you talking about Bug 387361 opened by you? Or Bug 392554?

both, thx, WADA.

IMO this is needed in many users' systems for proper operation of pop, and therefore not ENH.

This should be trivial to fix, however it seems there is still the open dependency on bug 315791. Can we proceed without this fixed? Is there agreement on this?

When I saw your ping of this bug, my first reaction was that downloadToTempFile has been the source of lots of issues in the past, so I would be reluctant to enable it by default for reliability reasons. Then I saw that you pointed out bug 315791, which is an excellent example of why I have that vague feeling of discomfort. Note also that dependent bug 527216 is resolved as dup to the unfixed Bug 548512 which may also be an issue here. Of course, the underlying bugs with this really should be fixed. But they are quite tricky to work on.

(In reply to Kent James (:rkent) from comment #12) > When I saw your ping of this bug, my first reaction was that > downloadToTempFile has been the source of lots of issues in the past, Thanks for the input. What issues/bug# do you refer to - issues unrelated to filters/bugs not in the blocking list? > so I would be reluctant to enable it by default for reliability reasons. Then I > saw that you pointed out bug 315791, which is an excellent example of why I > have that vague feeling of discomfort. Hans in bug 546430 comment 10 does indeed point out some very nasty things! So blockers would need to be fixed, and the entire area well tested to find other potential problems?

filter bugs that mention quarantine - https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=substring;list_id=5744669;field0-0-0=short_desc;type0-0-0=anywordssubstr;longdesc_type=allwordssubstr;type0-0-1=substring;field0-0-1=keywords;type1-0-1=allwordssubstr;resolution=---;classification=Client%20Software;classification=Components;query_format=advanced;longdesc=quarantine;component=Filters;field1-0-0=short_desc;product=MailNews%20Core;product=Thunderbird;field1-0-1=short_desc someone could check them for relevance to this bug? Joe, do you have any feedback from the mozillazine world?

(In reply to Wayne Mery (:wsmwk) from comment #14) > filter bugs that mention quarantine - > https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=substring;list_id=5744669; > field0-0-0=short_desc;type0-0-0=anywordssubstr;longdesc_type=allwordssubstr; > type0-0-1=substring;field0-0-1=keywords;type1-0-1=allwordssubstr;resolution=- > --;classification=Client%20Software;classification=Components; > query_format=advanced;longdesc=quarantine;component=Filters;field1-0- > 0=short_desc;product=MailNews%20Core;product=Thunderbird;field1-0- > 1=short_desc > > someone could check them for relevance to this bug? > > > Joe, do you have any feedback from the mozillazine world? Haven't seen much activity lately.My personal opinion would be to turn off email scanning completely. There is an article here, http://kb.mozillazine.org/Antivirus_software don't know how current it is though.

(In reply to Joe Sabash from comment #15) > (In reply to Wayne Mery (:wsmwk) from comment #14) > > filter bugs that mention quarantine - > > https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=substring;list_id=5744669; > > field0-0-0=short_desc;type0-0-0=anywordssubstr;longdesc_type=allwordssubstr; > > type0-0-1=substring;field0-0-1=keywords;type1-0-1=allwordssubstr;resolution=- > > --;classification=Client%20Software;classification=Components; > > query_format=advanced;longdesc=quarantine;component=Filters;field1-0- > > 0=short_desc;product=MailNews%20Core;product=Thunderbird;field1-0- > > 1=short_desc > > > > someone could check them for relevance to this bug? > > > > > > Joe, do you have any feedback from the mozillazine world? > > Haven't seen much activity lately.My personal opinion would be to turn off > email scanning completely. There is an article here, > http://kb.mozillazine.org/Antivirus_software don't know how current it is > though. good point. but we offer no hints in our UI either in prefs or at account creation. Also, - do we how good AV vendors are at excluding thunderbird? - some seem to break often, - some like proxying themselves in the network which has proven to have its own problems - (I'm sure there is more)

(Trying to process old requests) Re comment 13 "Thanks for the input. What issues/bug# do you refer to - issues unrelated to filters/bugs not in the blocking list?" I don't have any specific issues beyond the bugs mentioned. It's just that the quarantine of individual messages involves additional operations, and is not as thoroughly tested as the main path. But I would have no objection to enabling it many cycles before release if the existing dependencies were fixed.

(In reply to Joe Sabash from comment #15) > (In reply to Wayne Mery (:wsmwk) from comment #14) > > filter bugs that mention quarantine - > > https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=substring;list_id=5744669; > > field0-0-0=short_desc;type0-0-0=anywordssubstr;longdesc_type=allwordssubstr; > > type0-0-1=substring;field0-0-1=keywords;type1-0-1=allwordssubstr;resolution=- > > --;classification=Client%20Software;classification=Components; > > query_format=advanced;longdesc=quarantine;component=Filters;field1-0- > > 0=short_desc;product=MailNews%20Core;product=Thunderbird;field1-0- > > 1=short_desc > > > > someone could check them for relevance to this bug? > > > > > > Joe, do you have any feedback from the mozillazine world? > > Haven't seen much activity lately.My personal opinion would be to turn off > email scanning completely. There is an article here, > http://kb.mozillazine.org/Antivirus_software don't know how current it is > though. The problem with no "protection via thunderbird" is we know users report loss of mail folders due to antivirus scanning of Thunderbird profiles. Yes, AV shouldn't be scanning us - but they do. And even when they don't (normally) they sometimes break when Thunderbird updates - like McAfee has a few times in the last year. N.B. they also scan the temp directory - a caveat to bug 315791