Show user preference for SPOCs if Discoverystream is on
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
People
(Reporter: k88hudson, Assigned: andreio)
References
Details
(Keywords: github-merged)
User Story
QA Steps:
1. In a fresh profile, Discovery Stream enabled and SPOCs enabled
* example value pref: `{"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}`
2. In `about:preferences#home` there should be a link at the end of the Firefox Home description and a checked checkbox with the text `Sponsored Stories`
* link points to https://getpocket.com/firefox/new_tab_learn_more
* mock has `Show sponsored stories` but we are reusing the strings from Topstories
3. Checking off the checkbox should set `browser.newtabpage.activity-stream.showSponsored` to false and no more sponsored stories should be visible in about:newtab/home
Attachments
(3 files, 1 obsolete file)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-github-pull-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
Experiment preferences mock
Right now we only show an opt-out preference, but we also need to show an option for sponsored content.
|
Reporter | |
Updated•6 years ago
|
|
||
Comment 1•6 years ago
|
||
Let's make the following updates to the pref based on the attached spec…
- add a learn more link, it should link to https://getpocket.com/firefox/new_tab_learn_more
- Add a checkbox for showing SPOCs, it should be checked by default. Label copy should be "Show sponsored stories"
And here's a Figma link to the spec
https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-Home-Modules?node-id=895%3A1
|
Assignee | |
Updated•6 years ago
|
This would mean adding strings, which we try to avoid doing in beta because it is a burden on the l10n team, which is mostly volunteers. Is this shown for other locales than en-US?
|
||
Comment 3•6 years ago
|
||
This would be for en-US. Activity stream strings already normally land in nightly and shouldn't be uplifted to a mozilla-beta triggering localization. If this gets uplifted, we'll want to make sure newtab/locales-src changes but not browser/locales/en-US
|
|
Reporter | |
Comment 4•6 years ago
|
||
Additionally, I think this would use the same string as the existing pref (it just needs to be shown instead of hidden)
|
||
Comment 5•6 years ago
|
||
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 6•6 years ago
|
||
This PR reuses existing strings, no new strings added.
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 7•6 years ago
|
||
|
|
Reporter | |
Updated•6 years ago
|
|
|
Reporter | |
Comment 8•6 years ago
|
||
|
|
Reporter | |
Comment 10•6 years ago
|
||
|
|
Reporter | |
Updated•6 years ago
|
|
|
||
Comment 11•6 years ago
|
||
Comment on attachment 9044265 [details]
Bug 1525366 - Show user preference for SPOCs if Discoverystream is on
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
None
User impact if declined
users wouldn't be able to disable sponsored content on their new tab pages 😬
Is this code covered by automated tests?
Yes
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
Yes
If yes, steps to reproduce
see User Story
List of other uplifts needed
None
Risk to taking this patch
Medium
Why is the change risky/not risky? (and alternatives if risky)
This patch is a bit bigger than other patches and renders a user facing UI, but it's a single preference and can be very easily (and manually) verified and tested. It is also a critical component for running required experiments
String changes made/needed
none (see comment 6)
|
|
||
Comment 12•6 years ago
|
||
I have verified in Nightly 67.0a1 on Mac OS 10.14.3 the following…
- there is a link at the end of the Firefox Home description and beneath that a checked checkbox with the label
Sponsored Stories - the link above points to https://getpocket.com/firefox/new_tab_learn_more
- unchecking the Sponsored Stories checkbox sets
browser.newtabpage.activity-stream.showSponsoredtofalsein the config - no Sponsored Stories are displayed on New Tab after unchecking the checkbox
Comment on attachment 9044265 [details]
Bug 1525366 - Show user preference for SPOCs if Discoverystream is on
Planned work for pocket/new tab. Verified in Nightly.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.
|
||
Comment 14•6 years ago
|
||
| bugherder uplift | ||
|
||
Comment 15•6 years ago
|
||
(In reply to Wolasi from comment #12)
I have verified in Nightly 67.0a1 on Mac OS 10.14.3 the following…
- there is a link at the end of the Firefox Home description and beneath
that a checked checkbox with the labelSponsored Stories- the link above points to https://getpocket.com/firefox/new_tab_learn_more
- unchecking the Sponsored Stories checkbox sets
browser.newtabpage.activity-stream.showSponsoredtofalsein the config- no Sponsored Stories are displayed on New Tab after unchecking the checkbox
Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?
|
|
||
Comment 16•6 years ago
|
||
I have verified in Firefox Beta 66.0b9 on Mac OS 10.14.3 the following…
- there is a link at the end of the Firefox Home description and beneath that a checked checkbox with the label Sponsored Stories
- the link above points to
https://getpocket.com/firefox/new_tab_learn_more - unchecking the Sponsored Stories checkbox sets
browser.newtabpage.activity-stream.showSponsoredtofalsein the config - no Sponsored Stories are displayed on New Tab after unchecking the checkbox
|
|
||
Updated•6 years ago
|
|
||
Updated•5 years ago
|
Description
•