Large blank area in the search results on Preferences when searching for 'pass'. See attached screenshot.

This is not reproducible on mozregression but multiple people have reported it.

It looks like the cause is that #homeContentsGroup has an inline style of visibility: hidden which is overriding the visiblity: collapse that is applied through the .visibly-hidden class.

Looks to be caused by https://searchfox.org/mozilla-central/rev/cb7faaf6b4ad2528390186f1ce64618dea71031e/browser/components/newtab/lib/AboutPreferences.jsm#273

This will affect 66 users who are in the experiment.

https://hg.mozilla.org/mozilla-central/rev/abe819688f32

Gavin, Can you add some QA steps for this?

Brahmini can you QA?

I didn't work on this one, sorry.

Ed, can you add in steps for QA?

QA steps:

1. visit about:preferences
2. with the in-content search box near the top, type "pass"
3. make sure there's not a lot of empty space between sections (it should show main sections: Network Settings then Login & Passwords then Certificates)

note: in step 3 before the fix, it looks like only Network Settings shows up because there's so much empty space before the next one

I have verified in Nightly 67.0a1 on Mac OS 10.14.3, there is no longer a large space between the Network Settings and Login & Password sections

Comment on attachment 9044270 [details]
Bug 1527626 - Large blank area in the search results on Preferences when searching for pass

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

ugly UX in pref search

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

(see comment 9)

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

this is a small patch that affects styling. It is very easy to verify and is isolated to the preferences pane

String changes made/needed

Comment on attachment 9044270 [details]
Bug 1527626 - Large blank area in the search results on Preferences when searching for pass

Planned work for pocket/new tab. Verified in Nightly.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.

https://hg.mozilla.org/releases/mozilla-beta/rev/6d44d7639157

(In reply to Wolasi from comment #10)

I have verified in Nightly 67.0a1 on Mac OS 10.14.3, there is no longer a
large space between the Network Settings and Login & Password sections

Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?

I have verified in Beta 66.0b9 on Mac OS 10.14.3, there is no longer a large space between the Network Settings and Login & Password sections.

(In reply to Wolasi from comment #16)

I have verified in Beta 66.0b9 on Mac OS 10.14.3, there is no longer a large
space between the Network Settings and Login & Password sections.

Thanks for verifying this!