New Tab : Incorrect numbers listed for numbered list sections
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox65 | --- | unaffected |
firefox66 | + | verified |
firefox67 | --- | verified |
People
(Reporter: bnagabandi, Assigned: thecount)
References
Details
(Keywords: github-merged, regression)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
As of today's build
FF Nightly version : 67.0a1 (2019-02-10)
OS : Mac and Windows 10 Pro
Latest end-point dev-test-all
has incorrect numbers for all numbered list sections.
Comment 1•6 years ago
|
||
I would guess bug 1519879 regressed this with the changes to the html structure of lists?
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
To test:
- Set the pref
browser.newtabpage.activity-stream.discoverystream.config
to{"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
- Go to about:home
- Scroll down a bit until you see a numbered list item. (Should be just below the fold, three numbers items with circle blue list numbers)
Expected: Should see a list going 1, 2, 3.
Actual: See a list with items going 1, 1, 1.
Assignee | ||
Comment 4•6 years ago
|
||
This is caused by the spoc changes to List, we added the intersection observer component around the list item element, which now breaks it out of the css needed for content: counter(list); which seems to make it think it's a bunch of 1 item lists.
One initial option is to swap the li element and the intersection observer component's order, seems to fix it and list spocs still works?
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 7•6 years ago
|
||
Fixes numbering list regressed in bug 1519879 fix.
Comment 8•6 years ago
|
||
Updated•6 years ago
|
Comment 9•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
Brahmini, can you verify that the list numbers are fixed on nightly? See steps here: https://bugzilla.mozilla.org/show_bug.cgi?id=1526861#c3
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Comment 13•6 years ago
|
||
Comment on attachment 9043739 [details]
Bug 1526861 - Incorrect numbers listed for numbered list sections
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
User will see list items incorrectly numbered
Is this code covered by automated tests?
No
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
Yes
If yes, steps to reproduce
- Set the pref browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
- Go to about:home
- Scroll down a bit until you see a numbered list item. (Should be just below the fold, three numbers items with circle blue list numbers)
Expected: Should see a list going 1, 2, 3.
Actual: See a list with items going 1, 1, 1.
List of other uplifts needed
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
Very low risk small patch. Fixes regression from 1519879 patch that displays sponsored content in list for discovery new tab experiments.
String changes made/needed
None
Comment 14•6 years ago
|
||
I have verified in Nightly 67.0a1 on Mac OS 10.14.3 that the numbers for the numbered list module are being displayed correctly!
Comment on attachment 9043739 [details]
Bug 1526861 - Incorrect numbers listed for numbered list sections
Planned work for pocket/new tab. Verified in Nightly.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.
Comment 16•6 years ago
|
||
bugherder uplift |
Comment 17•6 years ago
|
||
(In reply to Wolasi from comment #14)
I have verified in Nightly 67.0a1 on Mac OS 10.14.3 that the numbers for the
numbered list module are being displayed correctly!
Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?
Comment 18•6 years ago
|
||
I have verified in Beta 66.0b9 on Mac OS 10.14.3 that the numbers for the numbered list module are being displayed correctly
Updated•6 years ago
|
Comment 19•6 years ago
|
||
(In reply to Wolasi from comment #18)
I have verified in Beta 66.0b9 on Mac OS 10.14.3 that the numbers for the
numbered list module are being displayed correctly
Thanks for verifying this!
Updated•6 years ago
|
Updated•5 years ago
|
Description
•