Closed Bug 1527397 Opened 6 years ago Closed 6 years ago

[Hero] Update layout for full-width hero

Categories

(Firefox :: New Tab Page, defect, P1)

66 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 67
Iteration:
67.1 - Jan 28 - Feb 10
Tracking Status
firefox66 + verified
firefox67 --- verified

People

(Reporter: wolasi, Assigned: gsuntop)

References

Details

(Keywords: github-merged)

Attachments

(2 files)

Update layout per Figma Spec
https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-Home-Modules?node-id=15%3A0

Please note the changes to the line clamping for the title and excerpt for the primary/first story in the hero, they change based on the size of the hero unit. Ping me @wolasi on slack if further details are required

Any chance you could make the source for the first story in the hero align to the bottom of the container using flexbox?

Iteration: --- → 67.1 - Jan 28 - Feb 10
Priority: -- → P1
Summary: [Hero] Update layout or full-width hero → [Hero] Update layout for full-width hero
Blocks: 1528119
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Can you add some steps for this and ask Wolasi to take a look possibly?

Flags: needinfo?(gsuntop)

Gavin, Can you add some QA steps for this?

Wolasi can you QA?

Flags: needinfo?(wkonu)

Wolasi has already QA'd this and it's gone through code review. I don't believe it needs further QA.

Flags: needinfo?(wkonu)
Flags: needinfo?(gsuntop)

I have verified in Nightly 67.0a1 on Mac OS 10.14.3, the full-width hero layout has been updated as spec'ed.

Status: RESOLVED → VERIFIED

Comment on attachment 9044273 [details]
Bug 1527397 - Update layout for full-width hero in Discovery Stream

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1527397

User impact if declined

Hero component will display in a sub-optimal way in which sub-items will be below the hero graphic.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Primarily CSS changes with very minimal HTML tweaks.

String changes made/needed

Attachment #9044273 - Flags: approval-mozilla-beta?

Comment on attachment 9044273 [details]
Bug 1527397 - Update layout for full-width hero in Discovery Stream

Planned work for pocket/new tab. Verified in Nightly.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.

Attachment #9044273 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Wolasi from comment #8)

I have verified in Nightly 67.0a1 on Mac OS 10.14.3, the full-width hero
layout has been updated as spec'ed.

Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?

Flags: qe-verify+
Flags: needinfo?(wkonu)

I have verified in Beta v66.0b9 on Mac OS 10.14.3, the full-width hero layout has been updated as spec'ed.

Flags: needinfo?(wkonu)

(In reply to Wolasi from comment #13)

I have verified in Beta v66.0b9 on Mac OS 10.14.3, the full-width hero
layout has been updated as spec'ed.

Thanks for verifying this!

Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: