Closed
Bug 189598
Opened 22 years ago
Closed 22 years ago
application/octet-stream handlers should not be remembered automatically
Categories
(Core Graveyard :: File Handling, defect)
Core Graveyard
File Handling
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bzbarsky, Assigned: pkwarren)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bzbarsky
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
The problem is that we do not want to be remembering any
"application/octet-stream to extension" or "application/octet-stream to helper"
associations. If the user explicitly enters such in the helper app prefs, that
is fine. But otherwise, we should _not_ remember these and the "Always show
this dialog" box should be checked and _disabled_ to indicate what's going on.
pkw, interested in this one?
Assignee | ||
Comment 1•22 years ago
|
||
I'll take a look at this.
Assignee | ||
Comment 2•22 years ago
|
||
If the mime type is listed as application/octet-stream then disable the
checkbox and set the alwaysAsk checkbox to true.
Reporter | ||
Comment 3•22 years ago
|
||
Comment on attachment 112094 [details] [diff] [review]
First attempt
You also want to make sure not to persist the user's decision to prefs...
Attachment #112094 -
Flags: review-
Assignee | ||
Comment 4•22 years ago
|
||
Don't update helper application preferences for application/octet-stream.
Attachment #112094 -
Attachment is obsolete: true
Assignee | ||
Updated•22 years ago
|
Attachment #112100 -
Flags: review?(bzbarsky)
Reporter | ||
Comment 6•22 years ago
|
||
Comment on attachment 112100 [details] [diff] [review]
Second attempt
looks good. :)
Attachment #112100 -
Flags: superreview?(jaggernaut)
Attachment #112100 -
Flags: review?(bzbarsky)
Attachment #112100 -
Flags: review+
Comment 7•22 years ago
|
||
Comment on attachment 112100 [details] [diff] [review]
Second attempt
sr=jag
Attachment #112100 -
Flags: superreview?(jaggernaut) → superreview+
Assignee | ||
Comment 8•22 years ago
|
||
Fixed with last night's checkin.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 9•22 years ago
|
||
Looking for a test case to help me verify this fix. Any ideas ?
Reporter | ||
Comment 10•22 years ago
|
||
Added testcase to URL field. ;)
Comment 11•22 years ago
|
||
Ok, this works fine on the 2003-01-23-07 OS Mach-0 build with the test case
provided. However, I'm having a problem opening this test case under the win32
(2003-01-24-08) build. I basically get a download error that states the source
could not be read. This could be related to
http://bugzilla.mozilla.org/show_bug.cgi?id=190465.
Reporter | ||
Comment 12•22 years ago
|
||
Almost certainly. Marking dependent so this can be verified once that's fixed.
Depends on: 190465
Comment 13•22 years ago
|
||
Verified in the Win32 2003-01-25-08 trunk build under Windows XP.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 14•22 years ago
|
||
*** Bug 191647 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 15•22 years ago
|
||
*** Bug 192138 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 16•22 years ago
|
||
*** Bug 192580 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 17•22 years ago
|
||
*** Bug 150736 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 18•22 years ago
|
||
*** Bug 192811 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 19•22 years ago
|
||
*** Bug 193781 has been marked as a duplicate of this bug. ***
Comment 20•22 years ago
|
||
*** Bug 194437 has been marked as a duplicate of this bug. ***
Comment 21•22 years ago
|
||
I have a quick question. If this bug has been fixed, why did I encounter the
problem in bug report #194437
(http://bugzilla.mozilla.org/show_bug.cgi?id=194437) using this build:
Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.3b) Gecko/20030218
It looks like this was fixed back in January.
Peace.....
Reporter | ||
Comment 22•22 years ago
|
||
Because at some point you used a build from before January. This bug was about
us creating a bogus helper app entry; wwith this patch in, we don't create new
such entries, but if you have one it sticks around till you delete it.
Comment 23•22 years ago
|
||
Gotcha....
I've deleted the "problematic" entry and all is well now.
Thanks!
Peace.....
Reporter | ||
Comment 24•22 years ago
|
||
*** Bug 195726 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 25•22 years ago
|
||
*** Bug 196528 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 26•22 years ago
|
||
*** Bug 193502 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 27•22 years ago
|
||
*** Bug 197192 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 28•22 years ago
|
||
*** Bug 197319 has been marked as a duplicate of this bug. ***
Comment 29•22 years ago
|
||
*** Bug 193502 has been marked as a duplicate of this bug. ***
Comment 30•22 years ago
|
||
*** Bug 197809 has been marked as a duplicate of this bug. ***
Comment 31•22 years ago
|
||
*** Bug 191328 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 32•22 years ago
|
||
*** Bug 200221 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 33•22 years ago
|
||
*** Bug 200477 has been marked as a duplicate of this bug. ***
Comment 34•22 years ago
|
||
*** Bug 200880 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 35•22 years ago
|
||
*** Bug 201948 has been marked as a duplicate of this bug. ***
Comment 36•22 years ago
|
||
What Mozilla release was this fixed in? Is that info displayed on this Bugzilla
form anywhere?
Peace...
Comment 37•22 years ago
|
||
*** Bug 202118 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 38•21 years ago
|
||
*** Bug 205279 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 39•21 years ago
|
||
*** Bug 205381 has been marked as a duplicate of this bug. ***
Comment 40•21 years ago
|
||
*** Bug 205678 has been marked as a duplicate of this bug. ***
Comment 41•21 years ago
|
||
*** Bug 204666 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 42•21 years ago
|
||
*** Bug 208751 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 43•21 years ago
|
||
*** Bug 212234 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 44•21 years ago
|
||
*** Bug 212443 has been marked as a duplicate of this bug. ***
Comment 45•21 years ago
|
||
*** Bug 219098 has been marked as a duplicate of this bug. ***
Comment 46•21 years ago
|
||
*** Bug 221771 has been marked as a duplicate of this bug. ***
Comment 47•21 years ago
|
||
*** Bug 210958 has been marked as a duplicate of this bug. ***
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•